Fix Windows WebView icon fallback to use executable icon#709
Merged
AlbertShown merged 1 commit intoJul 24, 2026
Merged
Conversation
AlbertShown
approved these changes
Jul 24, 2026
Member
|
Thank you @ViktorJannicke, much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #708
Summary
Improve the Windows WebView window-icon fallback sequence:
IDI_APPLICATIONresource.Motivation
WebUI currently loads resource 101 and then immediately uses the generic system icon when that resource is absent.
Windows applications commonly store their executable application icon under
IDI_APPLICATION(resource 32512). As a result, an executable can be correctly branded in Explorer while its WebUI window, taskbar button, caption, and Alt+Tab entry display the generic icon.Using
wc.hInstancewithIDI_APPLICATIONloads the resource from the executable. The existingLoadIcon(NULL, IDI_APPLICATION)call remains the final system fallback.Compatibility
IDI_APPLICATIONnow receive their embedded icon.Testing
Built successfully on Windows with MSVC as:
WEBUI_WEBVIEW_STATIC