Repository navigation
[20.0][MIG] base_geoengine_demo: Migration to 20.0 - #10
weinni2000 wants to merge 1 commit into
Conversation
Assisted-by: Claude Code (claude-opus-5-5)
9701e9b to
dc6a118
Compare
6e4f362 to
2e42129
Compare
Reviewer's guide (collapsed on small PRs)Reviewer's GuideMigrates base_geoengine_demo to Odoo 20 by updating module metadata and access-file conventions, while configuring the pending 20.0 base_geoengine dependency and PostGIS-backed CI environment required for installation and tests. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/test.yml" line_range="49" />
<code_context>
services:
postgres:
- image: postgres:16
+ image: postgis/postgis:16-3.4
env:
POSTGRES_USER: odoo
</code_context>
<issue_to_address>
**CI fails before tests**
When the pull request workflow runs with the added test requirement pointing to PR #489, `unreleased-deps` scans `test-requirements.txt`, matches the Git URL, and exits with status 1, so the workflow fails before tests run.
Update the `unreleased-deps` check to allow this Git URL.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 1 finding to address first, and the new access rules grant the geoengine user group CRUD access to retail-machine records, and the purported admin rule is also assigned to that group. If that scope is unintended, users can read or change records while this is deployed; reverting stops future access but does not undo changes or prior exposure.
Blocking findings: .github/workflows/test.yml:49
| services: | ||
| postgres: | ||
| image: postgres:16 | ||
| image: postgis/postgis:16-3.4 |
There was a problem hiding this comment.
🔴 Critical · CI fails before tests
When the pull request workflow runs with the added test requirement pointing to PR OCA#489, unreleased-deps scans test-requirements.txt, matches the Git URL, and exits with status 1, so the workflow fails before tests run.
Update the unreleased-deps check to allow this Git URL.
Prompt for AI agents
In `.github/workflows/test.yml` at line 49:
**CI fails before tests**
When the pull request workflow runs with the added test requirement pointing to PR #489, `unreleased-deps` scans `test-requirements.txt`, matches the Git URL, and exits with status 1, so the workflow fails before tests run.
Update the `unreleased-deps` check to allow this Git URL.
security/ir.model.access.csvtosecurity/ir.access.csv.test-requirements.txt: installbase_geoenginefrom the 20.0 migration [20.0][MIG] base_geoengine: Migration to 20.0 OCA/geospatial#489, which is not merged yet.postgis/postgis:16-3.4image (postgres_imagecopier answer), as in [20.0][MIG] base_geoengine: Migration to 20.0 OCA/geospatial#489;base_geoengineneeds PostGIS to install.Based on the 19.0 migration OCA#490.
Migrated with odev.
Assisted-by: Claude Code (claude-opus-5-5)
Summary by Sourcery
Migrate base_geoengine_demo to Odoo 20.0 with compatible security metadata and PostGIS-based test infrastructure.
Enhancements:
Build:
CI: