Skip to content

[20.0][MIG] base_geoengine_demo: Migration to 20.0 - #10

Open
weinni2000 wants to merge 1 commit into
20.0-mig-base_geoengine_demo-basefrom
20.0-mig-base_geoengine_demo
Open

weinni2000 wants to merge 1 commit into
20.0-mig-base_geoengine_demo-basefrom
20.0-mig-base_geoengine_demo

Conversation

@weinni2000

@weinni2000 weinni2000 commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Based on the 19.0 migration OCA#490.

Migrated with odev.

Assisted-by: Claude Code (claude-opus-5-5)

Summary by Sourcery

Migrate base_geoengine_demo to Odoo 20.0 with compatible security metadata and PostGIS-based test infrastructure.

Enhancements:

  • Migrate the base_geoengine_demo module to Odoo 20.0, including the updated access-control file format and module version.

Build:

  • Add the 20.0 base_geoengine migration dependency to the test requirements.

CI:

  • Run CI with PostGIS 16.3.4 to support installation and testing of base_geoengine.

Assisted-by: Claude Code (claude-opus-5-5)
@weinni2000
weinni2000 force-pushed the 20.0-mig-base_geoengine_demo branch from 9701e9b to dc6a118 Compare November 1, 2026 09:01
@weinni2000
weinni2000 force-pushed the 20.0-mig-base_geoengine_demo-base branch from 6e4f362 to 2e42129 Compare November 1, 2026 09:01
@sourcery-ai

sourcery-ai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Migrates base_geoengine_demo to Odoo 20 by updating module metadata and access-file conventions, while configuring the pending 20.0 base_geoengine dependency and PostGIS-backed CI environment required for installation and tests.

File-Level Changes

Change Details Files
Migrate the demo module metadata and access-control data to Odoo 20 conventions.
  • Bump the module version to 20.0.1.0.0.
  • Replace the legacy access CSV with ir.access.csv and update the manifest reference.
base_geoengine_demo/__manifest__.py
base_geoengine_demo/security/ir.access.csv
base_geoengine_demo/security/ir.model.access.csv
Align test dependencies and CI services with the PostGIS requirement of the migrated base_geoengine module.
  • Use the pending 20.0 base_geoengine migration as a test requirement.
  • Run CI against the postgis/postgis:16-3.4 database image.
test-requirements.txt
.github/workflows/test.yml
.copier-answers.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path=".github/workflows/test.yml" line_range="49" />
<code_context>
     services:
       postgres:
-        image: postgres:16
+        image: postgis/postgis:16-3.4
         env:
           POSTGRES_USER: odoo
</code_context>
<issue_to_address>
**CI fails before tests**

When the pull request workflow runs with the added test requirement pointing to PR #489, `unreleased-deps` scans `test-requirements.txt`, matches the Git URL, and exits with status 1, so the workflow fails before tests run.

Update the `unreleased-deps` check to allow this Git URL.
</issue_to_address>

Sourcery assessment

Needs a human reviewer. 1 finding to address first, and the new access rules grant the geoengine user group CRUD access to retail-machine records, and the purported admin rule is also assigned to that group. If that scope is unintended, users can read or change records while this is deployed; reverting stops future access but does not undo changes or prior exposure.

Blocking findings: .github/workflows/test.yml:49


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

services:
postgres:
image: postgres:16
image: postgis/postgis:16-3.4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical · CI fails before tests

When the pull request workflow runs with the added test requirement pointing to PR OCA#489, unreleased-deps scans test-requirements.txt, matches the Git URL, and exits with status 1, so the workflow fails before tests run.

Update the unreleased-deps check to allow this Git URL.

Prompt for AI agents
In `.github/workflows/test.yml` at line 49:

**CI fails before tests**

When the pull request workflow runs with the added test requirement pointing to PR #489, `unreleased-deps` scans `test-requirements.txt`, matches the Git URL, and exits with status 1, so the workflow fails before tests run.

Update the `unreleased-deps` check to allow this Git URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant