Skip to content

[19.0][MIG] geoengine_partner: Migration to 19.0 - #11

Open
weinni2000 wants to merge 31 commits into
19.0-mig-geoengine_partner-basefrom
19.0-mig-geoengine_partner
Open

weinni2000 wants to merge 31 commits into
19.0-mig-geoengine_partner-basefrom
19.0-mig-geoengine_partner

Conversation

@weinni2000

@weinni2000 weinni2000 commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Based on the 18.0 migration OCA#460.

Migrated with odev.

Assisted-by: Claude Code (claude-opus-5-5)

Summary by Sourcery

Migrate geoengine_partner to Odoo 19.0 while preserving partner mapping capabilities and aligning its geospatial dependencies and CI environment.

New Features:

  • Add partner geolocation support with editable map views and partner location layers in Odoo 19.0.

Enhancements:

  • Migrate the geoengine_partner module structure and metadata to the Odoo 19.0 format.
  • Update the contacts action to include the geospatial view in the Odoo 19.0 view order.

Build:

  • Use the PostGIS-backed PostgreSQL service required by the geospatial dependencies.

CI:

  • Update CI to run against the PostGIS 13-3.4 image.

Documentation:

  • Add OCA module documentation, usage guidance, translations, and generated module assets.

guewen and others added 30 commits November 1, 2026 10:05
…rs and view

Google still doesn't work but using OpenStreetMaps, it works.
Assisted-by: Claude Code (claude-opus-5-5)
@sourcery-ai

sourcery-ai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Data structures

Define the partner geo_point field that the migrated views and map layers depend on.

  • geoengine_partner/models/partner.py L1-12

UI

Add the partner map tab, geoengine view and layers, and update the contacts action for Odoo 19’s view order.

  • geoengine_partner/views/partner.xml L1-85

Configuration

Register the migrated module and its model and view files in the Odoo manifest.

  • geoengine_partner/__manifest__.py L1-15
  • geoengine_partner/models/__init__.py L1
  • geoengine_partner/__init__.py L1 (removed lines)

Use a PostGIS-enabled PostgreSQL service in CI and install the pending 19.0 base_geoengine dependency for tests.

  • .github/workflows/test.yml L45
  • geoengine_partner/pyproject.toml L1-3
  • test-requirements.txt L1

Documentation

Document installation and usage of the migrated partner geolocation module and include its generated module description and contributor list.

  • geoengine_partner/README.rst L1-106
  • geoengine_partner/readme/CONTRIBUTORS.md L1-9
  • geoengine_partner/readme/DESCRIPTION.md L1
  • geoengine_partner/readme/INSTALL.md L1
  • geoengine_partner/readme/USAGE.md L1-6
  • geoengine_partner/static/description/index.html L1-457
  • geoengine_partner/static/description/icon.png

Lock files and vendored code

Add the generated translation template and existing Italian and Chinese translations for the migrated module.

  • geoengine_partner/i18n/geoengine_partner.pot L1-75
  • geoengine_partner/i18n/it.po L1-78
  • geoengine_partner/i18n/zh_CN.po L1-78

Other changes

Files not grouped.

  • geoengine_partner/__openerp__.py (deleted)
  • geoengine_partner/geo_partner.py (deleted)
  • geoengine_partner/geo_partner_view.xml (deleted)

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path=".github/workflows/test.yml" line_range="45" />
<code_context>
     services:
       postgres:
-        image: postgres:13
+        image: postgis/postgis:13-3.4
         env:
           POSTGRES_USER: odoo
</code_context>
<issue_to_address>
**Dependency guard rejects test requirement**

When the added PR-465 Git URL is present in `test-requirements.txt`, the `unreleased-deps` job matches the Git URL’s slashes and exits with status 1, so the pull request’s CI fails before the tests can validate the migration.

Adjust the unreleased-dependency check to allow this intentional migration dependency until the upstream PR is merged.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: .github/workflows/test.yml:45


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

services:
postgres:
image: postgres:13
image: postgis/postgis:13-3.4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical · Dependency guard rejects test requirement

When the added PR-465 Git URL is present in test-requirements.txt, the unreleased-deps job matches the Git URL’s slashes and exits with status 1, so the pull request’s CI fails before the tests can validate the migration.

Adjust the unreleased-dependency check to allow this intentional migration dependency until the upstream PR is merged.

Prompt for AI agents
In `.github/workflows/test.yml` at line 45:

**Dependency guard rejects test requirement**

When the added PR-465 Git URL is present in `test-requirements.txt`, the `unreleased-deps` job matches the Git URL’s slashes and exits with status 1, so the pull request’s CI fails before the tests can validate the migration.

Adjust the unreleased-dependency check to allow this intentional migration dependency until the upstream PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants