Repository navigation
[19.0][MIG] geoengine_partner: Migration to 19.0 - #11
weinni2000 wants to merge 31 commits into
Conversation
…rs and view Google still doesn't work but using OpenStreetMaps, it works.
…tch actual requirement to be installable
This reverts commit 4a89ecb.
…ding _unported suffix
Assisted-by: Claude Code (claude-opus-5-5)
Reviewer's GuideData structuresDefine the partner geo_point field that the migrated views and map layers depend on.
UIAdd the partner map tab, geoengine view and layers, and update the contacts action for Odoo 19’s view order.
ConfigurationRegister the migrated module and its model and view files in the Odoo manifest.
Use a PostGIS-enabled PostgreSQL service in CI and install the pending 19.0 base_geoengine dependency for tests.
DocumentationDocument installation and usage of the migrated partner geolocation module and include its generated module description and contributor list.
Lock files and vendored codeAdd the generated translation template and existing Italian and Chinese translations for the migrated module.
Other changesFiles not grouped.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/test.yml" line_range="45" />
<code_context>
services:
postgres:
- image: postgres:13
+ image: postgis/postgis:13-3.4
env:
POSTGRES_USER: odoo
</code_context>
<issue_to_address>
**Dependency guard rejects test requirement**
When the added PR-465 Git URL is present in `test-requirements.txt`, the `unreleased-deps` job matches the Git URL’s slashes and exits with status 1, so the pull request’s CI fails before the tests can validate the migration.
Adjust the unreleased-dependency check to allow this intentional migration dependency until the upstream PR is merged.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: .github/workflows/test.yml:45
| services: | ||
| postgres: | ||
| image: postgres:13 | ||
| image: postgis/postgis:13-3.4 |
There was a problem hiding this comment.
🔴 Critical · Dependency guard rejects test requirement
When the added PR-465 Git URL is present in test-requirements.txt, the unreleased-deps job matches the Git URL’s slashes and exits with status 1, so the pull request’s CI fails before the tests can validate the migration.
Adjust the unreleased-dependency check to allow this intentional migration dependency until the upstream PR is merged.
Prompt for AI agents
In `.github/workflows/test.yml` at line 45:
**Dependency guard rejects test requirement**
When the added PR-465 Git URL is present in `test-requirements.txt`, the `unreleased-deps` job matches the Git URL’s slashes and exits with status 1, so the pull request’s CI fails before the tests can validate the migration.
Adjust the unreleased-dependency check to allow this intentional migration dependency until the upstream PR is merged.0bc6010 to
49f6ea9
Compare
titlefield,res.partner.titlewas removed in 19.0 (odoo/odoo@0b8bd891fad1).contacts.action_contacts: follow the new 19.0 view order (listbeforekanban) when addinggeoengine.test-requirements.txt: installbase_geoenginefrom the 19.0 migration [19.0][MIG] base_geoengine: consolidated migration OCA/geospatial#465, which is not merged yet.postgis/postgis:13-3.4image, as in [19.0][MIG] base_geoengine: consolidated migration OCA/geospatial#465;base_geoengineneeds PostGIS to install.Based on the 18.0 migration OCA#460.
Migrated with odev.
Assisted-by: Claude Code (claude-opus-5-5)
Summary by Sourcery
Migrate geoengine_partner to Odoo 19.0 while preserving partner mapping capabilities and aligning its geospatial dependencies and CI environment.
New Features:
Enhancements:
Build:
CI:
Documentation: