feat: support keyed nonce rpc queries - #493
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc05d79682
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import * as z_TransactionRequest from '../../TransactionRequest.js' | ||
| import * as z_Uint from '../../Uint.js' | ||
| import * as z from 'zod/mini' | ||
| import * as Frame from '../Frame.js' |
There was a problem hiding this comment.
Importing the Zod module namespace as Frame violates the repository-wide z_<Module> naming convention used by every neighboring schema import; rename it to z_Frame and update the new reference accordingly.
AGENTS.md reference: AGENTS.md:L14-L14
Useful? React with 👍 / 👎.
| params: z.tuple([ | ||
| z_Address.Address, | ||
| BlockNumberOrTagOrIdentifier, | ||
| z.optional(Frame.nonceKeysToRpc), |
There was a problem hiding this comment.
When a keyed nonce sequence is above Number.MAX_SAFE_INTEGER, this method still decodes its result through z_Number.Number, whose output schema rejects values above that limit. EIP-8250 sequences are valid through 2^64 - 2 (as enforced by src/core/internal/frameNonce.ts), so a valid keyed query result such as 0x20000000000000 now fails decoding; the return codec needs a bigint-capable representation while preserving legacy behavior where required.
Useful? React with 👍 / 👎.
This branch was successfully deployed
1 participant
Added optional
nonceKeystoeth_getTransactionCounttypes and codecs, preserving account nonce requests and scalar results under the EIP-8250 extension in ethereum/execution-apis#907.