Skip to content

docs(changelog): drop trailing periods added to nine fragments - #4328

Merged
bpamiri merged 1 commit into
developfrom
peter/lift-docs-batch4
Oct 5, 2026
Merged

bpamiri merged 1 commit into
developfrom
peter/lift-docs-batch4

Conversation

@bpamiri

@bpamiri bpamiri commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

#4319, #4320 and #4323 added a final period to nine changelog.d fragments. #4319's description said other bullets carry one, and that was wrong. Changelog bullets conventionally end with the issue reference and no period: in the published 4.1.2 section, 67 of 68 bullets end (#NNNN).

This PR reverts those nine periods, and nothing else:

  • 4149-controller-construction.performance
  • oracle-beyond-64bit.fixed
  • 4172-wide-decimal-exact-bind.fixed
  • 4174-promote-globals-metadata.performance
  • 4187-singularize-prefixed-analyses.changed
  • 4095-migrator-unsupported-column-type.changed
  • 4134-migration-lock.changed
  • 4189-singularize-databases.changed
  • tx-advisory-locks.added: this also restores its original … behaviour). ([#4198](…)) ending, instead of …)).

The other fragments on develop are mixed (some end with a period) and are left as they are. tools/changelog-promote.sh --preview renders.

🤖 Generated with Claude Code

Changelog bullets end with the issue reference and no period (the 4.1.2
section: 67 of 68 bullets). Revert the periods added to nine fragments in
#4319, #4320 and #4323, which also restores tx-advisory-locks' ending.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the docs label Oct 5, 2026
@bpamiri

bpamiri commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

Review @ a98ee52: APPROVE (changelog fragments only)

  • Only the periods change. For each of the 9 fragments, develop's content equals this PR's content plus a final .. Nothing else in any fragment changes.
  • The convention is right. In the v4.1.2 section of CHANGELOG.md, 67 of 68 bullets end with ) and none ends with )., so dropping the period after (#NNNN) matches the published changelog.
  • tx-advisory-locks is back to ending … ([#4198](…)), which resolves my earlier cosmetic INFO.

No findings.

@bpamiri
bpamiri merged commit 752eebe into develop Oct 5, 2026
15 checks passed
@bpamiri
bpamiri deleted the peter/lift-docs-batch4 branch October 5, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant