Repository navigation
build: refresh tooling lockfiles - #4363
Merged
Merged
Conversation
Re-resolve the root dev-tooling lock and the TestUI lock within their existing package.json ranges (npm update --package-lock-only). No manifest changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
Nothing in the TestUI app, its Dockerfiles, scripts, CI or tools uses puppeteer. Removing it also removes the Chrome download from the Docker build stage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
Collaborator
Author
|
rev1-r3 review @ 69aa03a: approve in substance (final sign-off after PR CI)
|
Collaborator
Author
|
rev1-r3 review @ 69aa03a: APPROVE (final; PR CI checked) PR CI on this head: 12 pass, 3 skipped, 0 failing or pending. That includes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refreshes two npm lockfiles and removes one dev dependency nothing uses.
package-lock.json(repo root, dev tooling only: commitlint, husky, tsx, Playwright test, the issue-resolver scripts). Re-resolved within its existingpackage.jsonranges (npm update --package-lock-only). The manifest is unchanged.tools/docker/testui/(the TestUI Vue app):puppeteerdevDependency is dropped. It was unused: nothing in the app's source, itspackage.jsonscripts, the Dockerfiles or shell scripts,.github/workflows,tools/or any test-runner config references it. The only other repo hits are a Puppeteer MCP server's tool names inexamples/tweet/, which is unrelated to the npm package.npm install, removing it also takes the Chrome download out of the Docker build stage.dist/, sonode_modulesnever shipped either way.This is the non-
web/counterpart of #4362's lock refresh.Verification
npm ci --ignore-scriptspasses, andcommitlintaccepts a valid header and rejects an invalid one.npm ci --ignore-scriptsandnpm run build(vite) pass.npm run type-checkin TestUI reports the samePreflightStatus.vueparse errors with develop's lock as with this one. That is pre-existing, not touched here, and not run in CI.🤖 Generated with Claude Code