Repository navigation
docs: note bulk-write transactions and callbacks=false in the app guide - #4386
Merged
Merged
Conversation
Collaborator
Author
|
Review: head 218998e. APPROVE (docs). I checked each line against
PR CI at review time: 1 pass, 13 pending, 2 skipping. The final follows once it is green. |
There is no transaction() function. Say where a bulk call joins an open transaction, and that its default comes from transactionMode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows up #4377 now that two behaviour fixes have landed. It touches
docs/consumer-ai/.ai/models.mdand itswheels newtemplate copy.insertAll()andupsertAll()run all of a call's batches in one transaction by default, so a failing batch keeps none of the call's rows.transaction()the call joins it.transaction="none"commits batch by batch, and"rollback"writes nothing.afterCommit/afterRollback(fix(model): skip commit callbacks when callbacks = false #4378):save(callbacks=false)anddelete(callbacks=false)skip them along with every other callback.Checked against
vendor/wheels/model/bulk.cfmandcallbacks.cfmon develop (eb99bc9).Verification
tools/build/scripts/ship-consumer-docs.sh checkpasses, and the template copy is byte-identical.🤖 Generated with Claude Code