Repository navigation
docs(test): describe recorded queries and appCache keys accurately in docblocks - #4453
Merged
Merged
Conversation
… docblocks - recordQueries() / $recordQuery(): bound values become ?, and a value written into the SQL itself (parameterize=false) appears as written; they said values are never recorded. - appCacheFetch() / appCacheRead(): keys are shared by every user, session, tenant and host, and a full cache returns the computed value uncached. Comments only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
Collaborator
Author
|
Review: head f9159e9. APPROVE (comment-only).
The gate is PR CI (7 pass, 14 pending at review time). The final follows once it's green. |
Collaborator
Author
|
FINAL: APPROVE. Head f9159e9.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comments only. Three docblocks now match the behaviour and the docs:
WheelsTest.recordQueries()andBase.$recordQuery()said values are "never recorded". Bound values become?, but a value written into the SQL itself (parameterize=false) appears as written. This matches the testing guide and.ai/testing.mdsince feat(test): assert how many SQL statements a spec's call sends #4357.appCacheFetch()andappCacheRead()now say:"digest-" & userId);appCacheFetch()returns the computed value without caching it.This matches the caching guide and
.ai/caching.mdsince feat: add appCacheFetch() and friends for caching your own data #4388.Tests
No code changed (the diff touches only
*comment lines). Compile check on Lucee 7 + SQLite:🤖 Generated with Claude Code