Repository navigation
docs: softDelete=false alone purges already soft-deleted rows - #4454
Merged
Merged
Conversation
Collaborator
Author
|
Review: head 494a1a2. APPROVE (docs).
The final follows PR CI. |
Collaborator
Author
|
FINAL: APPROVE. Head 494a1a2.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #4397 (#4371),
delete()/deleteAll()/deleteOne()/deleteByKey()withsoftDelete=falseare always real deletes, including rows that are already soft-deleted. This updates the one bullet in the consumermodels.md(and itswheels newtemplate copy) that still told readers to also passincludeSoftDeletes=truefor those rows.#4397 already added the new behaviour to the summary paragraph in the same file. This brings the soft-delete section's bullet in line with it.
tools/build/scripts/ship-consumer-docs.sh checkpasses, and the template copy is identical.🤖 Generated with Claude Code