Repository navigation
build(docker): verify the SQLite JDBC jar's SHA-256 in the Lucee test images - #4598
Conversation
… images The Lucee 5, 6 and 7 test images download sqlite-jdbc-3.50.3.0.jar with wget, which fails the build on an HTTP error but never checked the bytes. A damaged or substituted jar would be baked into the image and only show up at test time. Each image now checks the jar against Maven Central's published SHA-256 (the same pin as tools/ci/fetch-sqlite-jdbc.sh) and fails the build on a mismatch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
Wheels Test Results14 924 tests 14 625 ✅ 3m 51s ⏱️ Results for commit a81f053. |
|
rev1-r3 review @ a81f053: APPROVE The hash matches. All three Dockerfiles pin
A mismatch fails the build. The check is the last command of the Lucee 5 (not in the matrix), read: the change is identical in shape to Matrix 38543017972 (lucee6 and lucee7 × sqlite): both images built, and the build logs show the check passing:
Both legs ran 7462 tests, 0 fail, 0 error. PR CI: 17 pass, 3 skipping, 0 fail, cold-start adobe2023/2025/boxlang/lucee7 included. Up to date with develop, MERGEABLE. |
Summary
The Lucee 5, 6 and 7 test images (
tools/docker/lucee{5,6,7}/Dockerfile) downloadsqlite-jdbc-3.50.3.0.jarwithwget. That fails the build on an HTTP error, but never checked the bytes, so a damaged or substituted jar would be baked into the image and only show up at test time.Each image now pipes the downloaded jar through
sha256sum -c -against Maven Central's published SHA-256. It's the same pintools/ci/fetch-sqlite-jdbc.shuses (#4594), and a mismatch fails the image build.Fixes #4595 for the SQLite JDBC jar. The H2 and Oracle
.lexextensions the images also fetch are unchanged.Verification
In the pinned
ortussolutions/commandboxbase image, I ran the exactRUNcommands (wgetdownload, thensha256sum -c -):/opt/wheels-lib/sqlite-jdbc-3.50.3.0.jar: OK, exit 0FAILED, exit 1, which fails theRUNstepThe images themselves are built by the compat matrix.
🤖 Generated with Claude Code