Repository navigation
docs(cli): correct the deploy e2e fixture README's Keys paragraph - #4603
Merged
Merged
Conversation
The paragraph said the e2e keys were copied verbatim from the sshd/ fixture. sshd/ no longer has an authorized_keys, and the e2e keypair is its own. Describe what the fixture actually holds: its own test keypair, an authorized_keys that is a byte-identical copy of test_key.pub (bind-mounted by docker-compose.yml), and why it is not shared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Keys" paragraph in
cli/lucli/tests/_fixtures/deploy/e2e/README.mdsaid the fixture'stest_key,test_key.pubandauthorized_keyswere copied verbatim from the siblingsshd/fixture. That is no longer true:sshd/has noauthorized_keys;sshd/'s.The paragraph now describes what the fixture actually holds:
authorized_keysthat is a byte-identical copy oftest_key.pub, bind-mounted read-only bydocker-compose.yml;E2EDeploySpecfinds the key at<fixtureDir>/test_key.Docs only; one paragraph.
Verification
ssh-keygen -yontest_keymatchestest_key.pub.cmpshowsauthorized_keysis identical totest_key.pub.sshd/authorized_keysis absent, andcmpshowse2e/test_keydiffers fromsshd/test_key.🤖 Generated with Claude Code