Repository navigation
test(wheelstest): pin that gate-skipped browser specs are reported as Skipped - #4623
Merged
Merged
Conversation
… Skipped BrowserDescribeSkipSpec only proves that a skipped browserDescribe() spec body doesn't run. Nothing checked what TestBox records for it. If the skip path went back to returning quietly instead of calling skip(), every browser spec would be counted as Passed again and that spec would still pass. A fixture under tests/resources/wheelstest forces the browser gate to skip in beforeAll(), with no Playwright or network. A new spec runs it through a nested TestBox (the same pattern as BDDRunnerErrorReportingSpec) and asserts the spec is recorded as Skipped with its reason, with no pass, fail or error. Turning the skip path into a quiet return makes the new spec fail, and flips the 32 real browser specs from Skipped to Passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
Contributor
Wheels Test Results7 470 tests 7 321 ✅ 2m 36s ⏱️ Results for commit 1434517. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BrowserDescribeSkipSpeconly proves that a skippedbrowserDescribe()spec body doesn't run. Nothing pinned what TestBox records for it. If the skip path regressed to returning quietly instead of callingskip(), which was the behaviour #4263 fixed, every browser spec would be counted as Passed and the existing self-test would still pass.This adds:
vendor/wheels/tests/resources/wheelstest/BrowserDescribeSkippedFixture.cfc. ItsbeforeAll()calls$skipBrowserSpecs(reason), so the gate skips deterministically, with no Playwright or network. It sits outsidetests/specs, so the suite doesn't discover it as a bundle.vendor/wheels/tests/specs/wheelstest/BrowserDescribeSkippedStatusSpec.cfc. It runs the fixture through a nested TestBox (the same pattern asBDDRunnerErrorReportingSpec) and asserts:Skipped;Tests only.
Testing
browserDescribe()'s skip branch temporarily changed toreturn;, the new spec fails ("Expected [0] but received [1]"), and the 32 real browser specs flip from Skipped to Passed. After reverting (byte-identical), it's green again.directory=wheels.tests.specs.wheelstest: the new spec passes on Lucee 7, Adobe 2023, BoxLang and RustCFML. The outer skipped count is unchanged, and the fixture is never discovered as its own bundle.wheels.tests.specsruns: Lucee 7 and BoxLang 7318/0/0, Adobe 2023 7313/0/0, each 601 bundles. RustCFML's full and targeted runs show only its existing failures, with identical identities before and after.🤖 Generated with Claude Code