Skip to content

Fix Pages deploy failure by pinning rust-cache action to v2 - #1

Closed
wheevu with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-github-actions-deploy-job
Closed

wheevu with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-github-actions-deploy-job

Conversation

Copilot AI commented Oct 2, 2026 •

Copy link
Copy Markdown

The deploy job in the Pages workflow failed before build/deploy due to an unresolved GitHub Action reference (Swatinem/rust-cache@main). This updates the workflow to use a resolvable, stable action version so the deploy pipeline can proceed.

  • Root cause

    • pages.yml referenced Swatinem/rust-cache@main, which is not resolvable in GitHub Actions for this workflow run.
  • Workflow fix

    • Updated the Pages deploy job cache step to pin Swatinem/rust-cache to @v2.
    • Kept existing workspace cache layout unchanged (. -> target, wasm -> wasm/target) to preserve current behavior.
  • Example change

    - name: Cache cargo
      uses: Swatinem/rust-cache@v2
      with:
        workspaces: |
          . -> target
          wasm -> wasm/target

Copilot AI changed the title [WIP] Fix failing GitHub Actions job deploy Fix Pages deploy failure by pinning rust-cache action to v2 Oct 2, 2026
Copilot AI requested a review from wheevu October 2, 2026 17:10
@wheevu

wheevu commented Oct 2, 2026

Copy link
Copy Markdown
Owner

Closing as superseded. The diagnosis was right: Swatinem/rust-cache@main does not resolve, and @v2 is what ci.yml already used.

The same fix reached main as c309fb3, together with two further fixes the deploy needed, both of which only appeared once the workflow ran for the first time:

  • The artifact check read the WebAssembly magic with od -An -c | grep, which can never match. GNU od prints \0 where BSD od prints 0, and the pattern expected six bytes for a four-byte magic. It now reads hex.
  • Staging copied all of site/ and deleted only the README afterwards, so it would have published the new browser tests, the npm manifest and the Playwright config to the public URL. It is now an allowlist of the thirteen page files.

main is green, Pages deployed from 112800e, and the page is live at https://wheevu.github.io/muninn/.

@wheevu wheevu closed this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants