Repository navigation
ci: treat tools/e3sm_l1kpm_v2/ as documentation tooling in the code-change gate - #135
Merged
Merged
Conversation
…hange gate detect_code_changes.sh lists only tools/oran_docx/ as non-code. A pull request that adds the generator of the E3SM-L1-KPM specification under tools/e3sm_l1kpm_v2/ next to the specification therefore counted as a code change, and the unit tests, the E2E jobs and the full-loop benchmark ran in full for a pull request that changes no library file. Add the directory to the non-code list, next to tools/oran_docx/. Assisted-by: Claude:claude-sonnet-5-5 Signed-off-by: Thecave3 <thecave003@gmail.com>
Contributor
CI report —
|
| Workflow | Result | Time | Run |
|---|---|---|---|
| Commit policy | ✅ success (steps skipped — no code changes) | 1m06s | #205 |
| Docs | ✅ success | 0m42s | #13 |
| E2E dApp Integration | ✅ success (steps skipped — no code changes) | 0m41s | #195 |
| E2E Topologies (multi-dApp / multi-RAN) | ✅ success (steps skipped — no code changes) | 1m19s | #193 |
| Full-loop Latency Benchmark | ✅ success (steps skipped — no code changes) | 0m48s | #194 |
| Unit Tests | ✅ success (steps skipped — no code changes) | 1m27s | #221 |
| Build libe3py wheels | ⏭️ not triggered (paths filter) | — | — |
| latrec portability | ⏭️ not triggered (paths filter) | — | — |
| MPMC Queue Benchmark | ⏭️ not triggered (paths filter) | — | — |
Ready to merge (fast-forward only)
A maintainer can land the reviewed commits with:
git fetch origin
git checkout main && git merge --ff-only af98e5cefde3bebc12560ba095c1e0d385c6b6f1 && git push origin mainHead: af98e5cefde3bebc12560ba095c1e0d385c6b6f1 (branch ci/detect-code-changes-e3sm-tools). If --ff-only fails as non-fast-forward, the branch must be rebased on the latest main.
One comment per PR, rewritten in place once every workflow for
af98e5cfinished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request that adds the generator of the E3SM-L1-KPM specification under
tools/e3sm_l1kpm_v2/next to the specification counted as a code change, becausedetect_code_changes.shlists onlytools/oran_docx/as non-code. The unit tests, the E2E jobs and the full-loop benchmark then ran in full for a pull request that changes no library file. This is what happened on an earlier push of #134.The directory is added to the non-code list next to
tools/oran_docx/. Nothing else undertools/changes classification.