Repository navigation
docs: record that libe3 keeps the timestamp in the root of the E3-PDU - #141
Merged
Merged
Conversation
libe3's E3-PDU puts the optional timestamp before the message. OCUDU's native module puts it after the extension marker and keeps libe3's order only in its libe3-compatible codec, so a stamped PDU encodes to different bytes on the two. Record the position on the interop page: libe3 keeps its order, which is the one OAI runs and which changing would be a wire change for libe3, OAI's E3 agent and the dApp library together, and the move is OCUDU's. Add the placement to the field contracts and the decision to the OCUDU row. No libe3 change, so no ledger row. Refs #114 Assisted-by: Claude:claude-sonnet-5-5 Signed-off-by: Thecave3 <thecave003@gmail.com>
3 of 15 tasks
Contributor
CI report —
|
| Workflow | Result | Time | Run |
|---|---|---|---|
| Commit policy | ✅ success (steps skipped — no code changes) | 0m27s | #222 |
| Docs | ✅ success | 3m17s | #26 |
| Build libe3py wheels | ⏭️ not started (no changed file matches its paths filter) |
— | — |
| E2E dApp Integration | ⏭️ not started (no changed file matches its paths filter) |
— | — |
| E2E Topologies (multi-dApp / multi-RAN) | ⏭️ not started (no changed file matches its paths filter) |
— | — |
| Full-loop Latency Benchmark | ⏭️ not started (no changed file matches its paths filter) |
— | — |
| latrec portability | ⏭️ not started (no changed file matches its paths filter) |
— | — |
| MPMC Queue Benchmark | ⏭️ not started (no changed file matches its paths filter) |
— | — |
| Unit Tests | ⏭️ not started (no changed file matches its paths filter) |
— | — |
Docs
Doxygen warnings
0 warning(s) in the files this pull request changes, which fail the check; 403 more elsewhere, which do not. The full list is in the job log and the doxygen-warnings artifact of the Docs workflow.
Gaps in files this pull request does not change, by file:
| Warnings | File |
|---|---|
| 53 | include/libe3/types.hpp |
| 37 | include/libe3/sm_interface.hpp |
| 35 | include/libe3/e3_connector.hpp |
| 34 | include/libe3/e3_agent.hpp |
| 32 | include/libe3/e3_interface.hpp |
| 29 | include/libe3/c_api.h |
| 19 | src/c_api.cpp |
| 17 | include/libe3/logger.hpp |
| 17 | swig/libe3_swig.hpp |
| 17 | swig/e3_dapp_session.hpp |
Ready to merge (fast-forward only)
A maintainer can land the reviewed commits with:
git fetch origin
git checkout main && git merge --ff-only 42ee5a5b1a1b913f538fddfd1a4943059d62969b && git push origin mainHead: 42ee5a5b1a1b913f538fddfd1a4943059d62969b (branch docs/interop-timestamp-placement). If --ff-only fails as non-fast-forward, the branch must be rebased on the latest main.
One comment per PR, rewritten in place once every workflow for
42ee5a5finished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One documentation change to
docs/interop.md. No code, wire or version change, so no ledger row.Refs #114.
#114 found that the timestamp sits in different places in the
E3-PDU: libe3 has{ id, timestamp OPTIONAL, msg, ... }, OCUDU's native module has{ id, msg, ..., timestamp OPTIONAL }. Every stamped PDU encodes to different bytes on the two. This records the position:What changes on the page:
timestamprow in the field contracts table (libe3, Aerial, OCUDU), and a short paragraph under it stating the position;