Skip to content

Fix preset Quick Load button alignment - #5886

Merged
Aircoookie merged 1 commit into
mainfrom
quickload_btn_css_fix
Oct 5, 2026
Merged

Aircoookie merged 1 commit into
mainfrom
quickload_btn_css_fix

Conversation

@Aircoookie

@Aircoookie Aircoookie commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Issue
I've noticed a recent regression in UI CSS under specific circumstances. The Quick Load button text is always limited to two characters, however there are some quirks if the characters are wide WW or using non-latin characters such as CJK or emoji.

ql_alignment_issue_cjk

How to reproduce
Save a preset with quick load label such as two emoji, wide characters like "WW" or (most severe case) square characters like CJK "ある"

Fix
Turning off line wrapping on the quick load button fixes the severe vertical alignment issues with wide characters such as CJK.
Additionally, reduced horizontal padding reduces the amount of situations where the second character is partially clipped, improving overall visual appearance

ql_alignment_issue_cjk_after

Summary by CodeRabbit

  • Style
    • Updated the .psts display so its content stays on a single line, with a small amount of horizontal spacing on both sides. This may change how the content fits in narrow layouts.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
AGENTS.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: wled/WLED/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3dde2355-b39b-4d9d-92a5-3abc585d310b
📥 Commits

Reviewing files that changed from the base of the PR and between eb1a10b and 09c5e90.

📒 Files selected for processing (1)
  • wled00/data/index.css

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The .psts CSS rule now prevents content from wrapping and adds 1px of padding on each horizontal side.

Changes

.psts styling

Layer / File(s) Summary
Prevent wrapping and add horizontal padding
wled00/data/index.css
The .psts rule adds white-space: nowrap and 1px of padding on each side. Existing color and margin declarations remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: netmindz

Merge Risk: 🔵 Low · up to 09c5e

Quick Load buttons may clip unusually long labels saved through the JSON path, while normal editor labels remain unaffected. Presets remain selectable, so this is a bounded UI issue rather than a merge blocker.

Architecture Summary

Architecture risk: 🔵 Low · up to 09c5e

The change affects 1 system.

Changed systems: wled00

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — wled00 (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in wled00/data/index.css: The .psts rule adds white-space: nowrap and 1px left and right padding; its existing color and margin declarations are unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: fixing alignment of preset Quick Load buttons.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@softhack007 softhack007 added the bug label Oct 5, 2026
@Aircoookie
Aircoookie merged commit f491631 into main Oct 5, 2026
64 checks passed
@Aircoookie
Aircoookie deleted the quickload_btn_css_fix branch October 5, 2026 21:35
@softhack007

Copy link
Copy Markdown
Member

cherry-picked to 16_x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants