Repository navigation
Fix preset Quick Load button alignment - #5886
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe Changes
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: 🔵 Low · up to Quick Load buttons may clip unusually long labels saved through the JSON path, while normal editor labels remain unaffected. Presets remain selectable, so this is a bounded UI issue rather than a merge blocker. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
cherry-picked to |
Issue
I've noticed a recent regression in UI CSS under specific circumstances. The Quick Load button text is always limited to two characters, however there are some quirks if the characters are wide
WWor using non-latin characters such as CJK or emoji.How to reproduce
Save a preset with quick load label such as two emoji, wide characters like "WW" or (most severe case) square characters like CJK "ある"
Fix
Turning off line wrapping on the quick load button fixes the severe vertical alignment issues with wide characters such as CJK.
Additionally, reduced horizontal padding reduces the amount of situations where the second character is partially clipped, improving overall visual appearance
Summary by CodeRabbit
.pstsdisplay so its content stays on a single line, with a small amount of horizontal spacing on both sides. This may change how the content fits in narrow layouts.