fix: support llama.cpp runtimes across desktop platforms - #4
Open
FangzhiLi wants to merge 4 commits into
Open
Conversation
FangzhiLi
marked this pull request as ready for review
July 22, 2026 21:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The local Demo flow already used
llama-server, but the repo lookup and Electron packaging were tied to a single macOS runtime path. macOS Intel and Windows development could not reliably select their platform runtime, and Intel packaging was not reproducible from the current repo layout.User impact
Users on macOS ARM64, macOS Intel x64, and Windows x64 can use the bundled platform runtime without installing Ollama or llama.cpp separately. The Qwen GGUF model remains an on-demand download and is not committed to the repository.
Validation
PYTHONPATH=backend python3 -m unittest backend.tests.test_llama_runtime -v— 4 passedcd frontend && npm test— 131 passedmacos-arm64,macos-x64, andwindows-x64git diff --check upstream/main...HEAD— passedllama-server --versionboth report b9990 (259ae1df8)Follow-up validation
upstream/mainreference to the missingfrontend/src/components/icons/DbIconmodule; this PR does not modify that unrelated UI code.