feat: add secure Windows peer messaging - #29
Merged
Merged
Conversation
woai3c
marked this pull request as ready for review
August 29, 2026 02:45
woai3c
marked this pull request as draft
August 30, 2026 08:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal and acceptance criteria
Enable secure local peer discovery and cross-session messaging on Windows while preserving the existing macOS/Linux Unix-socket behavior.
Scope and design
Review disposition
PR_REVIEW_REPORT.md reviewed the original implementation revision c6fb0e5. Its four code findings were valid and are now addressed:
The fixes are in 9dff22a, a0ebd90, and 580258b. The report's remaining arm64-device, two-host, and human-acceptance items are evidence gaps rather than implementation defects and remain open below.
Verification evidence
GitHub CI
Local verification on Windows x64
Real multi-terminal acceptance smoke
Remaining acceptance evidence
Readiness