Add wolfTrust manual to shared documentation build - #283
Draft
aidangarske wants to merge 2 commits into
Draft
aidangarske wants to merge 2 commits into
aidangarske wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 3
Open (4)
Cloning/pulling the upstreammainbranch at build time makes builds non-reproducible and can… · New The update path assumes any existingwolftrust/.gitis the correct repository and remote; if the… · New Cloning/pulling the upstreammainbranch at build time makes builds non-reproducible and can… · New This description implies the build always reads from upstreammain, but the wrapper Makefile… · New
What changed in this PR
Adds wolfTrust to the shared documentation build pipeline by introducing a wolfTrust build entry point that pulls manual sources from the upstream wolfTrust repo and wiring it into the top-level Makefile and CI workflow.
Changes:
- Add
wolfTrust/Makefileto clone/update wolfTrust sources and build HTML/PDF viadocs_manual.py - Add
wolftrustto the top-levelmake alland create a dedicatedwolftrusttarget - Extend CI build-check workflow and update README to document the new target
| File | Description |
|---|---|
wolfTrust/Makefile |
Adds local wrapper to fetch wolfTrust sources and build HTML/PDF/all outputs |
wolfTrust/.gitignore |
Ignores generated build artifacts and the cloned wolftrust/ working directory |
README.md |
Documents the new make wolftrust target and explains source-of-truth location |
Makefile |
Adds wolftrust to all and defines wolftrust build target variables |
.github/workflows/build-check.yml |
Adds wolfTrust HTML/PDF build steps to CI |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Needs wolfSSL/wolfTrust#31