Skip to content

Skip unsupported SHA-1 and add PQC smoke examples - #614

Merged
dgarske merged 2 commits into
wolfSSL:masterfrom
aidangarske:fix/optional-sha1-examples
Sep 29, 2026
Merged

dgarske merged 2 commits into
wolfSSL:masterfrom
aidangarske:fix/optional-sha1-examples

Conversation

@aidangarske

Copy link
Copy Markdown
Member
  • Skip the benchmark's SHA-1 measurement when the TPM does not support it.
  • Add a smoke script for SHA-256, ML-DSA, and ML-KEM examples.
  • The script and benchmark passed against fwTPM built without SHA-1.

Copilot AI lite review requested due to automatic review settings September 28, 2026 21:21
@aidangarske aidangarske self-assigned this Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

This PR makes the benchmarking and example scripts work on TPM builds/configurations where SHA-1 is not available, and adds a PQC/SHA-256 smoke-test helper script.

Changes:

  • Skip the SHA-1 hash benchmark when the TPM reports SHA-1 as unsupported.
  • Add a no_sha1_examples.sh smoke script to run SHA-256 + PQC examples without requiring SHA-1.
  • Include the new script in the PQC EXTRA_DIST.
File Description
examples/​pqc/​no_sha1_examples.sh Adds a smoke script to run SHA-256 + PQC examples in SHA-1-free TPM builds.
examples/​pqc/​include.am Ensures the new smoke script is shipped in distribution artifacts.
examples/​bench/​bench.c Detects SHA-1 support and conditionally skips SHA-1 benchmarking to avoid failures.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread examples/pqc/no_sha1_examples.sh Outdated
Comment thread examples/bench/bench.c Outdated
@aidangarske
aidangarske requested a review from dgarske September 28, 2026 22:41
@aidangarske
aidangarske marked this pull request as ready for review September 28, 2026 22:41
@dgarske
dgarske merged commit a9cdc73 into wolfSSL:master Sep 29, 2026
265 of 269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants