Skip unsupported SHA-1 and add PQC smoke examples - #614
Merged
Merged
Conversation
aidangarske
commented
Sep 28, 2026
Member
- Skip the benchmark's SHA-1 measurement when the TPM does not support it.
- Add a smoke script for SHA-256, ML-DSA, and ML-KEM examples.
- The script and benchmark passed against fwTPM built without SHA-1.
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
This PR makes the benchmarking and example scripts work on TPM builds/configurations where SHA-1 is not available, and adds a PQC/SHA-256 smoke-test helper script.
Changes:
- Skip the SHA-1 hash benchmark when the TPM reports SHA-1 as unsupported.
- Add a
no_sha1_examples.shsmoke script to run SHA-256 + PQC examples without requiring SHA-1. - Include the new script in the PQC
EXTRA_DIST.
| File | Description |
|---|---|
| examples/pqc/no_sha1_examples.sh | Adds a smoke script to run SHA-256 + PQC examples in SHA-1-free TPM builds. |
| examples/pqc/include.am | Ensures the new smoke script is shipped in distribution artifacts. |
| examples/bench/bench.c | Detects SHA-1 support and conditionally skips SHA-1 benchmarking to avoid failures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aidangarske
marked this pull request as ready for review
September 28, 2026 22:41
dgarske
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

