Clarify SealSQ PQC builds and examples - #616
Merged
Merged
Conversation
aidangarske
commented
Sep 28, 2026
Member
- Separate SealSQ SPI, Linux kernel device, and fwTPM build instructions.
- mention /dev/tpm0 use in SealSQ TPM
- Show SHA-256 and PQC examples that do not require SHA-1 for SealSQ TPM
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 3
Open (3)
TheCFLAGS='-DTPM2_LINUX_DEV=\"/dev/tpm0\"'quoting is easy to mis-copy (especially across… · New These updated error messages removed the previously-mentioned--enable-experimentalrequirement.… · New These updated error messages removed the previously-mentioned--enable-experimentalrequirement.… · New
What changed in this PR
Improves documentation around building and running post-quantum (ML-DSA / ML-KEM) examples by separating fwTPM vs. SealSQ QVault hardware instructions and adding non-SHA-1 example invocations.
Changes:
- Reworked PQC example README to clearly split fwTPM vs. SealSQ QVault hardware usage, including
/dev/tpm0guidance. - Updated top-level README to add a dedicated “Hardware TPM: SealSQ QVault” build section and clarify PCR wording.
- Relaxed
configure.acv1.85/PQC dependency error messages for wolfSSL build flags.
| File | Description |
|---|---|
| examples/pqc/README.md | Separates fwTPM vs hardware instructions; adds /dev/tpm0 + non-SHA-1 example commands. |
| configure.ac | Updates autoconf error messages for wolfSSL v1.85/PQC prerequisites. |
| README.md | Adds hardware build section and non-SHA-1 example list; clarifies PCR description. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dgarske
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
