Skip to content

Clarify SealSQ PQC builds and examples - #616

Merged
dgarske merged 2 commits into
wolfSSL:masterfrom
aidangarske:docs/sealsq-pqc-builds
Sep 29, 2026
Merged

dgarske merged 2 commits into
wolfSSL:masterfrom
aidangarske:docs/sealsq-pqc-builds

Conversation

@aidangarske

Copy link
Copy Markdown
Member
  • Separate SealSQ SPI, Linux kernel device, and fwTPM build instructions.
  • mention /dev/tpm0 use in SealSQ TPM
  • Show SHA-256 and PQC examples that do not require SHA-1 for SealSQ TPM

@aidangarske aidangarske self-assigned this Sep 28, 2026
Copilot AI balanced review requested due to automatic review settings September 28, 2026 22:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 3 Medium severity

Open (3)
What changed in this PR

Improves documentation around building and running post-quantum (ML-DSA / ML-KEM) examples by separating fwTPM vs. SealSQ QVault hardware instructions and adding non-SHA-1 example invocations.

Changes:

  • Reworked PQC example README to clearly split fwTPM vs. SealSQ QVault hardware usage, including /dev/tpm0 guidance.
  • Updated top-level README to add a dedicated “Hardware TPM: SealSQ QVault” build section and clarify PCR wording.
  • Relaxed configure.ac v1.85/PQC dependency error messages for wolfSSL build flags.
File Description
examples/​pqc/​README.md Separates fwTPM vs hardware instructions; adds /dev/tpm0 + non-SHA-1 example commands.
configure.ac Updates autoconf error messages for wolfSSL v1.85/PQC prerequisites.
README.md Adds hardware build section and non-SHA-1 example list; clarifies PCR description.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md
Comment thread configure.ac
Comment thread configure.ac
@dgarske
dgarske merged commit a6da69f into wolfSSL:master Sep 29, 2026
265 of 269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants