Repository navigation
Convert wolfSSL to lib/wolfssl submodule - #624
Open
aidangarske wants to merge 2 commits into
Open
aidangarske wants to merge 2 commits into
aidangarske wants to merge 2 commits into
Conversation
aidangarske
commented
Oct 7, 2026
aidangarske
commented
Member
- Convert wolfSSL into lib/wolfssl submodule
- add dependabot submodule update for wolfspdm and wolfssl
- update docs to reflect new submodule
There was a problem hiding this comment.
🟡 Changes recommended
The fwTPM fresh-clone instructions omit required generation and RSA build options, resulting in failed or incomplete builds.
2 open findings
What changed in this PR
Converts wolfSSL to a pinned submodule and updates build documentation and automation accordingly.
Changes:
- Registers and documents
lib/wolfssl. - Adds pinned-submodule CI coverage.
- Enables daily Dependabot submodule updates.
| File | Description |
|---|---|
.gitmodules |
Registers wolfSSL submodule. |
.github/dependabot.yml |
Enables submodule updates. |
.github/workflows/wolfssl-submodule.yml |
Builds and tests the pinned wolfSSL revision. |
README.md |
Documents bundled wolfSSL builds. |
docs/README.md |
Updates general build instructions. |
docs/FWTPM.md |
Updates fwTPM prerequisites. |
docs/SWTPM.md |
Uses recursive checkout in QEMU. |
docs/WindowTBS.md |
Updates Windows build paths. |
examples/pqc/README.md |
Updates PQC build instructions. |
examples/spdm/README.md |
Updates SPDM prerequisite paths. |
src/spdm/README.md |
Updates detailed SPDM instructions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aidangarske
force-pushed
the
wolfssl-submodule
branch
2 times, most recently
from
October 7, 2026 20:21
d9ef400 to
6839b29
Compare
aidangarske
force-pushed
the
wolfssl-submodule
branch
from
October 8, 2026 15:38
6839b29 to
4dd1b73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.