Fix M33MU console marker failures in CI - #71
Open
aidangarske wants to merge 3 commits into
Open
aidangarske wants to merge 3 commits into
aidangarske wants to merge 3 commits into
Conversation
aidangarske
commented
Oct 2, 2026
Member
- Currently m33mu tests have been flaking because of mixed console outputs that get read wrong and report a CI failure
- Rejoin guest0 markers interrupted by UART banners or guest1 output.
- Share console parsing between CI and the local runner.
- Preserve raw logs and normal line boundaries.
- Reject missing bytes, faults, and missing guest1 markers.
- Pass 11 regression tests and 75 captured-log checks.
- Pass 200 hosted boots across both engines and guest variants under CPU load. (original run failed a few)
- Should actually close M33MU runs occasionally lose console output or shift interrupt timing on GitHub runners #34.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several local guest0 and conformance checks still bypass reconstruction, and the changes do not address the linked issue’s documented runtime failure.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds shared M33MU console reconstruction to reduce false marker failures caused by interleaved UART output.
Changes:
- Reconstructs guest0 output while preserving raw logs.
- Integrates parsing into local and CI runners.
- Adds regression tests and CI execution.
| File | Description |
|---|---|
tests/target/run_m33mu_scenario.sh |
Uses reconstructed output for selected checks. |
tests/target/lib/m33mu_console.py |
Implements console reconstruction. |
tests/scripts/test_m33mu_console.py |
Adds parser regression tests. |
Makefile |
Runs parser tests from make test. |
.github/workflows/unit-tests.yml |
Adds parser test coverage in CI. |
.github/workflows/m33mu.yml |
Uses reconstructed output for CI markers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
