Repository navigation
Filter accessibility snapshots by role and accessible name - #86
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3cefd3536
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wolfiesch
force-pushed
the
feat/snapshot-query
branch
from
October 26, 2026 07:48
1dba523 to
75b6720
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Accessibility snapshots could only be scoped by frame, root ref, depth, and node count. Locating one control (for example a "More message options" button in a large mail UI) required reading the whole tree, and
max_nodestruncated before the target was reached.Change
browser_snapshotinaccessibilitymode accepts an optionalquery: { role?, name? }:role: exact, case-insensitive AX role.name: case-insensitive substring of the accessible name (not description or value).max_nodes, composes withroot_ref/frame_id, keeps actionable refs and frame IDs, and setstruncatedwhen more matches exist. DOM editable fallbacks and the scripting outline are filtered the same way.query.Core RPC schema, host protocol types, MCP, OMP, Pi, the TypeScript SDK, README, and the MCP reference are updated together.
Verification
cargo testinhost-rs; protocol schema fixtures.query: {role: "button"}returned only the page button;query: {name: "LEARN"}returned the "Learn more" link and its text nodes;queryintextmode was rejected asinvalid_request.