Repository navigation
Make Windows host builds reproducible - #88
Merged
Merged
Conversation
The release workflow builds the host twice and compares the results. For x86_64-pc-windows-msvc the two builds differed at byte 257, the PE header timestamp the MSVC linker writes at link time, so the v2.0.0-rc.1 release run failed before signing. Link Windows MSVC targets with /Brepro through a root .cargo/config.toml, which every workflow picks up because cargo runs from the repository root. Verified on Windows 11 with VS 2022 Build Tools using the release workflow's build, clean, rebuild, and cmp steps: main differs at byte 257; with this change, two separate runs both produce identical binaries with the same SHA-256.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow builds the host twice and compares the results.
For x86_64-pc-windows-msvc the two builds differed at byte 257, the PE
header timestamp the MSVC linker writes at link time, so the v2.0.0-rc.1
release run failed before signing.
Link Windows MSVC targets with /Brepro through a root .cargo/config.toml,
which every workflow picks up because cargo runs from the repository root.
Verified on Windows 11 with VS 2022 Build Tools using the release
workflow's build, clean, rebuild, and cmp steps: main differs at byte
257; with this change, two separate runs both produce identical
binaries with the same SHA-256.