Skip to content

fix: Orb mini Configuration for github-runner and jenkins-runners and flashing rig - #1335

Merged
chrisgalanis merged 14 commits into
mainfrom
chris/nix-config-orb-mini
Aug 1, 2026
Merged

fix: Orb mini Configuration for github-runner and jenkins-runners and flashing rig#1335
chrisgalanis merged 14 commits into
mainfrom
chris/nix-config-orb-mini

Conversation

@chrisgalanis

@chrisgalanis chrisgalanis commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

.

@chrisgalanis
chrisgalanis requested a review from a team as a code owner July 30, 2026 19:20
@github-actions

Copy link
Copy Markdown

No concrete correctness, security, or merge-blocking issues found in the PR changes.

@github-actions

Copy link
Copy Markdown
  • Blocker: configuration.nix:17 and the equivalent SF config import ../orb-mini-runner.nix, but that file does not exist in the PR tree. Both NixOS configurations will fail to evaluate, preventing deployment. Please add the module or correct/remove the imports.

@github-actions

Copy link
Copy Markdown

No concrete correctness, security, or regression issues found in the PR changes. The shared Orb Mini configuration and runner environments appear internally consistent.

@chrisgalanis chrisgalanis changed the title fix: Orb mini Configuration for github-runenr and jenkins-runners fix: Orb mini Configuration for github-runner and jenkins-runners Jul 31, 2026
@chrisgalanis chrisgalanis changed the title fix: Orb mini Configuration for github-runner and jenkins-runners fix: Orb mini Configuration for github-runner and jenkins-runners and flashing rig Jul 31, 2026
@github-actions

Copy link
Copy Markdown

No concrete correctness, security, or merge-blocking issues found in the PR changes.

@github-actions

Copy link
Copy Markdown
  • nix/machines/orb-mini-runner.nix:10: The flashing-rig service uses an isolated Python containing only kivy and pyudev. boto3, declared for Mini runners below, is unavailable to this interpreter, so any flashing-rig AWS/S3 path will fail with ModuleNotFoundError. Include boto3 in flashingRigPython (or reuse the complete package set).

@github-actions

Copy link
Copy Markdown
  • [P1] nix/machines/orb-mini-runner.nix:82 — flashing-rig service depends on an unprovisioned checkout. Nothing in this PR creates %h/orb-mini-utils/flashing-rig. On a fresh deployment, systemd fails before ExecStart because WorkingDirectory is absent, then loops every five seconds. Provision the source declaratively or make the path configurable and ensure deployment creates it.

@github-actions

Copy link
Copy Markdown
  • nix/machines/orb-mini-runner.nix:78-80 — The flashing-rig unit creates an ordering cycle. WantedBy=graphical-session.target makes the target want and order itself after the service, while the service declares After=graphical-session.target. systemd may drop the service job when resolving this cycle. Remove the After/Wants pair or order it after graphical-session-pre.target instead.

@chrisgalanis
chrisgalanis enabled auto-merge (squash) August 1, 2026 17:41
Comment thread nix/machines/jenkins-agent.nix Outdated
Comment thread nix/machines/jenkins-agent.nix Outdated

systemd.tmpfiles.rules = [
"d ${cfg.workDir} 0755 ${agentUser} ${agentUser} - -"
"d /home/${agentUser} 0755 ${agentUser} ${agentUser} - -"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont just doing this

users.users.${agentUser} = {
  isNormalUser = true;
  home = "/home/jenkins-agent";
  createHome = true;
  extraGroups = [ "wheel" ] ++ cfg.extraGroups;
};

IN the user creation solve this? Do you want tmp on home?
What is going to be there?

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
  • [P1] Flashing-rig service creates a systemd ordering cyclenix/machines/orb-mini-runner.nix:78

    wantedBy = [ "graphical-session.target" ] makes the target want and order itself after this service, while after = [ "graphical-session.target" ] orders the service after the target. Systemd must break this cycle, potentially preventing the service from starting. Remove the after/wants relationship to graphical-session.target (or order after graphical-session-pre.target).

@chrisgalanis
chrisgalanis disabled auto-merge August 1, 2026 18:36
@chrisgalanis
chrisgalanis enabled auto-merge (squash) August 1, 2026 18:36
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
  • [P1] Flashing-rig Python omits boto3nix/machines/orb-mini-runner.nix:10

    The service runs the isolated flashingRigPython, containing only kivy and pyudev. Although boto3 is added to worldcoin.extraPythonPackages, that affects runner environments, not this interpreter. Any flashing-rig S3 operations will fail with ModuleNotFoundError. Include boto3 in flashingRigPython or build both environments from one package list.

@chrisgalanis
chrisgalanis merged commit 8acaa15 into main Aug 1, 2026
26 checks passed
@chrisgalanis
chrisgalanis deleted the chris/nix-config-orb-mini branch August 1, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants