You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Blocker:configuration.nix:17 and the equivalent SF config import ../orb-mini-runner.nix, but that file does not exist in the PR tree. Both NixOS configurations will fail to evaluate, preventing deployment. Please add the module or correct/remove the imports.
No concrete correctness, security, or regression issues found in the PR changes. The shared Orb Mini configuration and runner environments appear internally consistent.
chrisgalanis
changed the title
fix: Orb mini Configuration for github-runenr and jenkins-runners
fix: Orb mini Configuration for github-runner and jenkins-runners
Jul 31, 2026
chrisgalanis
changed the title
fix: Orb mini Configuration for github-runner and jenkins-runners
fix: Orb mini Configuration for github-runner and jenkins-runners and flashing rig
Jul 31, 2026
nix/machines/orb-mini-runner.nix:10: The flashing-rig service uses an isolated Python containing only kivy and pyudev. boto3, declared for Mini runners below, is unavailable to this interpreter, so any flashing-rig AWS/S3 path will fail with ModuleNotFoundError. Include boto3 in flashingRigPython (or reuse the complete package set).
[P1] nix/machines/orb-mini-runner.nix:82 — flashing-rig service depends on an unprovisioned checkout. Nothing in this PR creates %h/orb-mini-utils/flashing-rig. On a fresh deployment, systemd fails before ExecStart because WorkingDirectory is absent, then loops every five seconds. Provision the source declaratively or make the path configurable and ensure deployment creates it.
nix/machines/orb-mini-runner.nix:78-80 — The flashing-rig unit creates an ordering cycle. WantedBy=graphical-session.target makes the target want and order itself after the service, while the service declares After=graphical-session.target. systemd may drop the service job when resolving this cycle. Remove the After/Wants pair or order it after graphical-session-pre.target instead.
wantedBy = [ "graphical-session.target" ] makes the target want and order itself after this service, while after = [ "graphical-session.target" ] orders the service after the target. Systemd must break this cycle, potentially preventing the service from starting. Remove the after/wants relationship to graphical-session.target (or order after graphical-session-pre.target).
The service runs the isolated flashingRigPython, containing only kivy and pyudev. Although boto3 is added to worldcoin.extraPythonPackages, that affects runner environments, not this interpreter. Any flashing-rig S3 operations will fail with ModuleNotFoundError. Include boto3 in flashingRigPython or build both environments from one package list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.