Keep CopyService file access inside the checkpoint root - #26
Open
garagon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep files opened by CopyService inside its checkpoint root.
Sendreceives a checkpoint name, whileRegisterreceives a path prefix and name. Both eventually reachedmmap_file, which previously concatenated those values and opened the result without checking where it resolved. A client able to reach CopyService could therefore ask the service account to open a file outsideROOT_DIR.What changed
ROOT_DIR.SendandRegisterprefix behavior for valid checkpoint files.serial_testas a development dependency because existing library tests already use it.This is a service-boundary check. It does not assume CopyService is publicly reachable; impact depends on a client being able to call the service and on the service account's file permissions.
Validation
Validated on Linux in
rust:1-bookwormwith the package's native dependencies installed:cargo fmt --all -- --checkcargo test -p xai-recsys-engine --lib: 68 passed, 1 ignoredcargo clippy -p xai-recsys-engine --lib --tests -- -A clippy::useless-conversion -A clippy::collapsible-if -D warningsThe two allowed Clippy rules are pre-existing warnings in unchanged files.