Publish opt-in AgentDocs guidance and upgrade Trellis to alpha.539 - #73
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new virtual upstream links break canonical API-reference navigation outside AgentDocs installations.
Review effort: Balanced
Findings: 3
Open (3)
What changed in this PR
Migrates all three packages to opt-in AgentDocs guidance and upgrades the aligned Trellis dependencies to alpha.539.
Changes:
- Adds AgentDocs manifests, cross-package references, and consumer guidance.
- Removes legacy build-time documentation copying.
- Adds package conformance checks to CI and publishing workflows.
| File | Description |
|---|---|
Trellis.Yarp/src/Trellis.Yarp.csproj |
Registers YARP guidance. |
Trellis.Yarp/README.md |
Documents AgentDocs setup. |
Trellis.Yarp/NUGET_README.md |
Adds consumer instructions. |
Trellis.Microservices.AspNetCore/src/Trellis.Microservices.AspNetCore.csproj |
Registers consumer guidance. |
Trellis.Microservices.AspNetCore/README.md |
Documents AgentDocs setup. |
Trellis.Microservices.AspNetCore/NUGET_README.md |
Adds consumer instructions. |
Trellis.Microservices.Abstractions/src/Trellis.Microservices.Abstractions.csproj |
Registers contract and cookbook guidance. |
Trellis.Microservices.Abstractions/src/README.md |
Documents AgentDocs setup. |
Trellis.Microservices.Abstractions/src/NUGET_README.md |
Adds consumer instructions. |
README.md |
Describes guidance ownership and approval. |
docs/docfx_project/api_reference/trellis-api-yarp.md |
Replaces upstream links with virtual references. |
docs/docfx_project/api_reference/trellis-api-microservices-cookbook.md |
Documents virtual upstream guidance. |
docs/docfx_project/api_reference/trellis-api-internal-jwt.md |
Replaces upstream links with virtual references. |
Directory.Packages.props |
Upgrades Trellis and pins AgentDocs helper. |
Directory.Build.targets |
Defines packaged guidance and references. |
CHANGELOG.md |
Records migration and dependency upgrade. |
build/Trellis.ApiReference.targets |
Removes legacy copy logic. |
build/Trellis.ApiReference.Payload.targets |
Removes legacy payload targets. |
build/test-package-layout.ps1 |
Removes obsolete layout checks. |
build/test-guidance-packages.ps1 |
Adds package and consumer conformance testing. |
.github/workflows/publish-nuget-org.yml |
Validates guidance before publishing. |
.github/workflows/publish-github-packages.yml |
Validates guidance before publishing. |
.github/workflows/build.yml |
Packs and validates guidance on PRs. |
.gitattributes |
Stabilizes API-reference line endings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Trellis.AgentDocs.Packaging0.1.0-preview.20helper in all three NuGet packages. Remove the legacy restore/build-time instruction-copy targets; normal consumer restore and build no longer write repository instructions.trellis/documents throughupstream/aliases, replacing moving GitHub-main links in package copies without duplicating upstream guides. Canonical source guides retain navigable GitHub links; pack-time projection stages the virtual-reference form without changing source files.3.0.0-alpha.532to3.0.0-alpha.539, consuming Core's newly migrated complete first-party guidance bundle. Keep FluentAssertions at7.2.2because v8's licensing terms are not approved.Guidance is installed only with the independently versioned
Trellis.AgentDocstool and explicit approval of trusted publishers. References neither add NuGet dependencies nor bypass approval. JWT contracts and runtime authorization APIs are unchanged.Depends on the already merged and published Core publisher migration in xavierjohn/Trellis#800. The Copilot instructions also update the review-model preference from
gpt-5.5togpt-5.6-sol.Validation