Repository navigation
Fix streamed Codex command output - #906
Open
bartbunting wants to merge 1 commit into
Open
bartbunting wants to merge 1 commit into
bartbunting wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex can send command output through _meta.terminal_output_delta.data. Agent Shell currently reads content blocks and rawOutput.formatted_output, so command blocks show the command without its output.
This change accumulates output chunks per tool call and uses the retained output for rendering and transcripts. Status-only updates preserve that output, while complete content or raw-output snapshots replace it. Existing end-of-turn cleanup releases the accumulated state.
Tests cover interleaved commands, output delivered at completion, snapshot replacement, expansion and navigation, restored history, and cleanup.
Validation:
• Tests pass against source and with compiled code.
• No new warnings appear after checkdoc and byte compilation.
• Indentation and whitespace checks pass.
• Tested with Emacs 31.0.90.
Checklist
M-x checkdocandM-x byte-compile-file.