You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
get_xlsx_sheet_info's unreadable-workbook path and the malformed @ENCODING skip are untested #1006
Where:faircode/loaders_extra.py (get_xlsx_sheet_info() line 144, held_out_encoding_ignored_notes() lines 169-170), tests/test_loaders.py.
Current gap:get_xlsx_sheet_info() is meant to return None when a workbook cannot be opened or has no sheets, so the CLI and MCP notice stays silent and the real read error is reported instead; and held_out_encoding_ignored_notes() must skip a spec with a malformed @ENCODING suffix because the real parse reports it. Coverage shows neither branch runs, and a refactor that let these exceptions escape would turn a clean error into a traceback.
Suggested approach: a corrupt .xlsx (a text file with that suffix) asserting None, and held_out_encoding_ignored_notes(["h.xlsx=race@"], "latin-1") asserting [] and no exception.
Activity
test: a workbook without sheets and a malformed @encoding stay silent…
yakew7 commentedon Oct 16, 2026
Fixed in 6df5e42 (on main). Full suite green (941 passed).