Repository navigation
chore: add /assets/ catch-all to CODEOWNERS (fixes unowned assets/demo.gif) - #717
Merged
Merged
Conversation
… owner #711 added assets/demo.gif with no matching CODEOWNERS entry, which fails test_every_tracked_file_has_at_least_one_codeowners_owner. The test only runs in the profiler job, which skips docs-only changes, so it went unnoticed. A /assets/ catch-all placed above the specific asset entries covers this and any future README media without changing existing owners.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@ahmdkaml - new PR touching a path you own, please review. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#711 added
assets/demo.gifwith no matching CODEOWNERS entry, sotests/test_codeowners.py::test_every_tracked_file_has_at_least_one_codeowners_ownerfails onmain. It went unnoticed because that test only runs in theprofilerjob, which skips docs-only changes.This adds a
/assets/ @yakew7catch-all above the specific asset entries. CODEOWNERS uses the last matching rule, so the existing owners (profiler JS/CSS, explainers data, og, icons, fonts) don't change.Checks
pytest tests/test_codeowners.py: 7 passed (1 failed onmainbefore this change)Type
🤖 Generated with Claude Code