Skip to content

docs(codeowners): add profiler co-owners for assets/profiler-heldout.js #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yakew7 merged 1 commit into from
Oct 6, 2026
Merged

docs(codeowners): add profiler co-owners for assets/profiler-heldout.js #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
/assets/ @yakew7
/assets/profiler-engine.js @yakew7 @ahmdkaml
/assets/profiler-compare.js @yakew7 @ahmdkaml
/assets/profiler-heldout.js @yakew7 @ahmdkaml
/assets/profiler-ui.js @yakew7 @ahmdkaml
/assets/profiler.css @yakew7 @ahmdkaml
/profiler.html @yakew7 @ahmdkaml
Expand Down
18 changes: 18 additions & 0 deletions tests/test_codeowners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,3 +153,21 @@ def test_every_codeowners_owner_is_a_valid_github_handle():
if not handle_re.match(owner)
]
assert not bad, "\n".join(bad)


def test_profiler_scripts_are_co_owned():
entries = _parse_codeowners_paths()
owner_map = {pattern: owners for _line_no, pattern, owners in entries}
for script in [
"/assets/profiler-engine.js",
"/assets/profiler-compare.js",
"/assets/profiler-heldout.js",
"/assets/profiler-ui.js",
"/assets/profiler.css",
"/profiler.html",
]:
assert script in owner_map, f"{script} missing from CODEOWNERS"
assert "@yakew7" in owner_map[script] and "@ahmdkaml" in owner_map[script], (
f"{script} is not co-owned by @yakew7 and @ahmdkaml"
)

Loading