Repository navigation
fix(context): make injection strategy changes safely reversible - #644
Merged
Merged
Conversation
Owner
Author
|
Final review covers 9c4aa59. All five required contexts completed/success; branch CLEAN; no unresolved threads. Characterization preceded the two observed failing regressions. The fix restores only the exact owned factory, rejects foreign wrappers before mutation, and documents quiescent process-wide transitions and target recovery. Matrix, wheel and all SDK/local-host cells passed. Merge authorized by the maintainer’s explicit instruction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make context-injection strategy changes explicit and reversible without uninstalling another library's record factory.
Changes
Validation
958 passed, 4 skipped, 4 deselected, 13 warnings in 11.29s.make check-allandmake buildpassed:965 passed, 4 skipped, 4 deselected, 13 warnings in 10.88s; coverage 96.48%.Compatibility
True-to-False setup now restores the owned factory rather than leaving mixed injection active. Reconfigure only while logging is quiescent; keep passing
use_record_factory=Truefor repeated creation-time snapshot setup. Tear down integrations wrapping our factory before switching. No public API is removed.Related Issues
Closes #621
Merge authorized by the maintainer's explicit instruction, subject to exact-head required CI and resolved conversations.