Repository navigation
refactor(spec): extract OpenAPI version conversion helpers - #842
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Current-head maintainer authorization for the policy-bearing design update remains outstanding, and the merge checklist is incomplete.
No open issues 🎉
What changed in this PR
This final extraction PR for #819 separates schema version conversion from document compilation, preserving existing conversion behavior and diagnostic ordering.
Changes:
- Move recursive conversion, inline-schema traversal, and residual OpenAPI 3.0 compatibility checks into one private module.
- Retain compatibility re-exports in
spec.py, leaving existing tests and assertions unchanged. - Document the final compilation sequence and why each conversion pass remains necessary.
| File | Description |
|---|---|
src/azure_functions_openapi/spec.py |
Replace conversion implementations with compatibility re-exports. |
src/azure_functions_openapi/_schema_version_conversion.py |
Isolate the existing conversion family without registry or CLI dependencies. |
DESIGN.md |
Explain the conversion boundary, pass ordering, and retained work. |
Review effort: Balanced
yeongseon
force-pushed
the
refactor/spec-report-cli-local-diagnostics-819
branch
from
October 26, 2026 10:59
273ef5b to
3603b5f
Compare
Base automatically changed from
refactor/spec-report-cli-local-diagnostics-819
to
main
October 26, 2026 11:01
yeongseon
force-pushed
the
refactor/spec-isolate-version-conversion-819
branch
from
October 26, 2026 11:02
9bb349f to
bf51f0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move OpenAPI schema-version conversion into a private module to separate conversion logic from specification assembly.
Changes
_schema_version_conversion.py.spec.pyand preserve the existing conversion algorithms, warnings, exceptions, and public behavior.DESIGN.md. Existing tests and assertions remain unchanged.Validation
make test: 1,633 passed, 30 skipped, 22 deselected; coverage was 95.22% before and 95.25% after the extraction.make format-check,make lint,make typecheck,make build,make perf,make lint-workflows, andmake securitypassed.make check-allwas not run as a single command; its constituent checks were run individually. Cloud validation was not run.Related Issues
Refs #819
Final PR of the five-part series. Stacked on #841 → #840 → #838; #839 is an independent cleanup. Merge prerequisites first and close #819 after the entire series is merged.