Skip to content

refactor(api): use keyword forwarding behind explicit facade signatures - #853

Merged
yeongseon merged 1 commit into
mainfrom
refactor/848-facade-forwarding
Oct 26, 2026
Merged

yeongseon merged 1 commit into
mainfrom
refactor/848-facade-forwarding

Conversation

@yeongseon

Copy link
Copy Markdown
Owner

Summary

Reduce argument-order drift risk while preserving explicit public signatures, annotations and positional compatibility.

Changes

  • Use one consistent keyword-based forwarding pattern for JSON, YAML and report facades.
  • Keep the public parameter lists explicit for typing and IDE completion; no kwargs abstraction or code generation.
  • Characterization tests compare signatures and exercise every forwarding slot through positional and keyword calls.

Validation

  • Characterization before refactor: 9 passed, 1703 deselected in 1.84s.
  • make check-all passed: 1660 passed, 30 skipped, 22 deselected, 5 warnings in 26.57s; coverage remains above 95%.
  • make build passed. Repository mypy passed; LSP tooling cannot access private worktree paths.
  • GitHub CI pending.

Related Issues

Closes #848

Merge authorized by the maintainer’s explicit instruction.

@yeongseon
yeongseon merged commit 1bfec85 into main Oct 26, 2026
29 checks passed
@yeongseon
yeongseon deleted the refactor/848-facade-forwarding branch October 26, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(api): reduce duplicated public facade signatures safely

1 participant