Repository navigation
perf: avoid importing Pydantic v1 for v2 handlers - #604
Merged
Merged
Conversation
Owner
Author
|
Merge authorized by the maintainer’s explicit instruction. Reviewed sys.modules-based identity against existing v1 subclasses and v2 cold-import regression. Exact head b1204db: all five required contexts completed=success, no unresolved threads. Python 3.11 local make check-all build: 764 passed, 27 deselected, 4 warnings in 19.51s; 97.16% coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid importing the legacy Pydantic namespace solely to reject legacy models. A legacy class cannot exist without its module already being loaded, so consult sys.modules and retain real subclass recognition rather than module-name guessing.
Changes
Validation
Related Issues
Closes #594
Merge authorized by the maintainer’s explicit instruction.