Repository navigation
refactor: consolidate equivalent response exception branches - #610
Merged
Merged
Conversation
Owner
Author
|
Merge authorized by the maintainer’s explicit instruction. Reviewed deletion-only production change against characterization of response/formatter/logging parity. Exact head 26037a7 has all five required checks green and no unresolved threads. Local final summary: 809 passed, 27 deselected, 4 warnings in 18.07s; coverage 97.36%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove three specific exception handlers already handled identically by their adjacent Exception boundary. No new hierarchy or response behavior.
Changes
First characterize TypeError, ValueError and RuntimeError at validation, model serialization and direct serialization seams under both disclosure settings. Assert status, formatter identity policy and one log carrying the original exception. Remove only redundant handlers and unused import.
Validation
Characterization passed before refactoring: 809 passed, 27 deselected, 4 warnings in 18.00s. After refactoring Python 3.11 make check-all build: 809 passed, 27 deselected, 4 warnings in 18.07s; coverage 97.36%. Existing AdapterValidationError and serialization tests remain. GitHub CI pending.
Related Issues
Closes #598
Merge authorized by the maintainer’s explicit instruction.