feat: loosen itemSource mapping requirements

packages/visual-editor/locales/platform/en/visual-editor.json

@@ -344,7 +344,7 @@
   "inheritedDataMsg": "Data is inherited from the parent section.",
   "insight": "Insight",
   "item": "Item",
-  "itemSourceParentFieldTooltip": "List elements must be able to satisfy the mapping requirements:",
+  "itemSourceParentFieldTooltip": "List elements should be able to satisfy the mapping requirements:",
   "kilometer_zero": "kilometers",
   "kilometer_one": "kilometer",
   "kilometer_other": "kilometers",

packages/visual-editor/src/editor/yextEntityFieldUtils.test.ts

@@ -228,3 +228,89 @@ describe("getEntityFieldDisplayName", () => {
     ).toBe("c_linkedEntity");
   });
 });
+
+describe("item-source parent selection", () => {
+  it("allows item sources when any descendant type matches", () => {
+    const fields = getFieldsForSelector(
+      {
+        fields: [
+          {
+            name: "c_articles",
+            definition: {
+              name: "c_articles",
+              typeName: "c_articles",
+              isList: true,
+              type: {},
+            },
+            children: {
+              fields: [
+                {
+                  name: "title",
+                  definition: {
+                    name: "title",
+                    typeName: "type.string",
+                    type: {},
+                  },
+                },
+              ],
+            },
+          },
+        ],
+        displayNames: {
+          c_articles: "Articles",
+          "c_articles.title": "Articles > Title",
+        },
+      },
+      {
+        itemSourceTypes: [["type.image"], ["type.rich_text_v2"]],
+      }
+    );
+
+    expect(fields).toEqual(
+      expect.arrayContaining([
+        expect.objectContaining({
+          name: "c_articles",
+        }),
+      ])
+    );
+  });
+
+  it("hides item sources when no descendant types match", () => {
+    const fields = getFieldsForSelector(
+      {
+        fields: [
+          {
+            name: "c_articles",
+            definition: {
+              name: "c_articles",
+              typeName: "c_articles",
+              isList: true,
+              type: {},
+            },
+            children: {
+              fields: [
+                {
+                  name: "title",
+                  definition: {
+                    name: "title",
+                    typeName: "type.string",
+                    type: {},
+                  },
+                },
+              ],
+            },
+          },
+        ],
+        displayNames: {
+          c_articles: "Articles",
+          "c_articles.title": "Articles > Title",
+        },
+      },
+      {
+        itemSourceTypes: [["type.image"], ["type.cta"]],
+      }
+    );
+
+    expect(fields).toEqual([]);
+  });
+});

packages/visual-editor/src/editor/yextEntityFieldUtils.ts

@@ -1,4 +1,5 @@
 import {
+  type EntityFieldTypes,
   getFilteredEntityFields,
   getCompatibleEntityFieldTypes,
   RenderEntityFieldFilter,
@@ -317,7 +318,8 @@ const getScopedFieldsForSelector = (
  * 1. Scope to a selected source item when `sourceField` is provided.
  * 2. For item-source and mapped-source pickers, restrict roots to fields that
  *    can satisfy the required descendant type sets. `itemSourceTypes` takes
- *    precedence over `mappedSourceTypes` when both are present.
+ *    precedence over `mappedSourceTypes` when both are present and requires only
+ *    one matching group; mapped-source pickers require every group.
  * 3. Filter incompatible resolved values out when a stream document is
  *    available.
  * 4. Fall back to normal entity-field filtering for standard field selectors.
@@ -347,7 +349,7 @@ export const getFieldsForSelector = (
       }
     );
 
-    return requiredDescendantTypes.every((requiredTypes) =>
+    const matchesRequiredTypes = (requiredTypes: EntityFieldTypes[]): boolean =>
       availableFields.some(
         (availableField) =>
           getFilteredEntityFields(
@@ -357,8 +359,12 @@ export const getFieldsForSelector = (
               types: requiredTypes.flatMap(getCompatibleEntityFieldTypes),
             }
           ).length > 0
-      )
-    );
+      );
+
+    // One descendant match is enough for item-source selection.
+    return filter.itemSourceTypes?.length
+      ? requiredDescendantTypes.some(matchesRequiredTypes)
+      : requiredDescendantTypes.every(matchesRequiredTypes);
   };
 
   if (filter.itemSourceTypes?.length) {

packages/visual-editor/src/fields/EntityFieldSelectorField.test.tsx

@@ -658,7 +658,7 @@ describe("EntityFieldSelectorField", () => {
     expect(tooltip).toBeDefined();
     expect(
       within(tooltip).getByText(
-        "List elements must be able to satisfy the mapping requirements:"
+        "List elements should be able to satisfy the mapping requirements:"
       )
     ).toBeDefined();
     expect(within(tooltip).getByText("rich_text_v2")).toBeDefined();

packages/visual-editor/src/fields/EntityFieldSelectorField.tsx

@@ -402,7 +402,7 @@ export const ConstantValueModeToggler = ({
   const locale = i18n.language;
   const itemSourceParentFieldTooltipTitle = pt(
     "itemSourceParentFieldTooltip",
-    "List elements must be able to satisfy the mapping requirements:"
+    "List elements should be able to satisfy the mapping requirements:"
   );
 
   return (