Skip to content

fix: faq dom nesting - #1348

Merged
benlife5 merged 1 commit into
release/1.xfrom
dom-nesting-fix
Oct 2, 2026
Merged

benlife5 merged 1 commit into
release/1.xfrom
dom-nesting-fix

Conversation

@benlife5

@benlife5 benlife5 commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

resolvedAnswer is an RTF so it's wrapped in dev, so it can't be passed to <Body> which wraps in p. The variant is already applied by resolveComponentData, although we were missing the xs variant for RTF. I think this is the issue causing the minified react error from the bug bash.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 8b543ac4-38f5-41bd-841a-ebb88099183d

📥 Commits

Reviewing files that changed from the base of the PR and between 6315a83 and 718af70.

📒 Files selected for processing (2)
  • packages/visual-editor/src/components/atoms/maybeRTF.css
  • packages/visual-editor/src/components/pageSections/FAQsSection/FAQCard.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The stylesheet adds an .rtf-body-xs variant that sets paragraph and list-item font size to 4px below the body font-size token. The FAQ card now renders resolvedAnswer directly in AccordionContent, without the previous Body wrapper.

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 718af

This change fixes invalid DOM nesting in FAQ answers and adds a small-text variant for rich text. No concrete merge-blocking risk was found.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: fixing FAQ DOM nesting.
Description check ✅ Passed The description explains the DOM nesting issue, the rich text wrapper, the removed Body wrapper, and the missing xs variant. It relates directly to the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@benlife5
benlife5 merged commit 2bd3dbf into release/1.x Oct 2, 2026
17 checks passed
@benlife5
benlife5 deleted the dom-nesting-fix branch October 2, 2026 20:30
benlife5 added a commit that referenced this pull request Oct 2, 2026
benlife5 added a commit to yext-section-libraries/standard-library that referenced this pull request Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants