Repository navigation
fix: adjust yextve validate and deploy commands - #1352
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughDeployment API logging now accepts messages for expected response statuses. The section library lookup maps HTTP 404 to an informational “Section library not found” spinner status. Library ID validation now enforces a 2–63 character lowercase format, with required start and end characters. Tests cover spinner behavior and valid and invalid library IDs. Sequence Diagram(s)sequenceDiagram
participant getSectionLibrary
participant yextApiRequest
participant logApiCall
participant oraSpinner
getSectionLibrary->>yextApiRequest: Request section library with 404 message
yextApiRequest->>logApiCall: Pass expected status messages
logApiCall->>oraSpinner: Show informational status for mapped response
Suggested reviewers: Priority: ⬇️ Low Change: Bug fix Merge Risk: ⚪ Minimal · up to The validation and deploy-message changes appear ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adjusted validate to not allow "_" or other characters that'll fail in deploy.

Adjusted deploy to not show a temporary error when making a new section library.
Before:

After:

Also adjusted deploy to clearly state the issue when "yext_" prefix remains.