Skip to content

fix: adjust yextve validate and deploy commands - #1352

Merged
asanehisa merged 2 commits into
mainfrom
adjust-yextve
Oct 6, 2026
Merged

asanehisa merged 2 commits into
mainfrom
adjust-yextve

Conversation

@asanehisa

@asanehisa asanehisa commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Adjusted validate to not allow "_" or other characters that'll fail in deploy.
Screenshot 2026-10-06 at 10 27 44 AM

Adjusted deploy to not show a temporary error when making a new section library.

Before:
Screenshot 2026-10-06 at 10 07 23 AM

After:
Screenshot 2026-10-06 at 10 27 00 AM

Also adjusted deploy to clearly state the issue when "yext_" prefix remains.

@asanehisa
asanehisa requested review from a-friedman, benlife5 and jwartofsky-yext and removed request for benlife5 October 6, 2026 14:58
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 31d6270d-8a8e-4ce9-ae06-7120c8371e40
📥 Commits

Reviewing files that changed from the base of the PR and between 51300d9 and df312ab.

📒 Files selected for processing (7)
  • packages/visual-editor/src/cli/commands/internal/deploy/api.ts
  • packages/visual-editor/src/cli/commands/internal/deploy/deploy.test.ts
  • packages/visual-editor/src/cli/commands/internal/deploy/logging.ts
  • packages/visual-editor/src/cli/commands/internal/deploy/sectionLibraryApi.ts
  • packages/visual-editor/src/cli/yextve.test.ts
  • packages/visual-editor/src/internal/sectionLibraryValidation/stages/api/libraryMetadata.test.ts
  • packages/visual-editor/src/internal/sectionLibraryValidation/stages/api/libraryMetadata.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

Deployment API logging now accepts messages for expected response statuses. The section library lookup maps HTTP 404 to an informational “Section library not found” spinner status. Library ID validation now enforces a 2–63 character lowercase format, with required start and end characters. Tests cover spinner behavior and valid and invalid library IDs.

Sequence Diagram(s)

sequenceDiagram
  participant getSectionLibrary
  participant yextApiRequest
  participant logApiCall
  participant oraSpinner
  getSectionLibrary->>yextApiRequest: Request section library with 404 message
  yextApiRequest->>logApiCall: Pass expected status messages
  logApiCall->>oraSpinner: Show informational status for mapped response
Loading

Suggested reviewers: benlife5

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to df312

The validation and deploy-message changes appear ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the validation and deploy command changes.
Description check ✅ Passed The description explains the library ID validation changes and the deploy prompt behavior for missing section libraries.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

benlife5
benlife5 previously approved these changes Oct 6, 2026
@asanehisa
asanehisa merged commit 4c8711f into main Oct 6, 2026
16 checks passed
@asanehisa
asanehisa deleted the adjust-yextve branch October 6, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants