Skip to content

chore: improve convert-template error messages - #1353

Merged
benlife5 merged 1 commit into
mainfrom
convert-template-err-messages
Oct 6, 2026
Merged

benlife5 merged 1 commit into
mainfrom
convert-template-err-messages

Conversation

@benlife5

@benlife5 benlife5 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Improves some error messaging if the template conversion fails.

Will also update the docs at https://yext.atlassian.net/wiki/spaces/eng/pages/1466597451 for templates

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 06c4e39b-d38a-47b7-a3d1-dea22d87cdf9
📥 Commits

Reviewing files that changed from the base of the PR and between 4c8711f and d29389d.

📒 Files selected for processing (2)
  • packages/visual-editor/src/cli/commands/internal/convertTemplatesToSectionLibrary.test.ts
  • packages/visual-editor/src/cli/commands/internal/convertTemplatesToSectionLibrary.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

Template conversion now reports paths and field-specific details for invalid template identifiers, metadata, and layout structures. It also identifies normalized-ID collisions, reserved IDs, and conflicts with generated layout IDs. Metadata-list errors distinguish non-array values from unsupported entries. New tests cover these diagnostics.

Suggested reviewers: briantstephan

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to d2938

No actionable issue is established; the change is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the changeset’s main purpose: improving template conversion error messages.
Description check ✅ Passed The description identifies improved error messages for template conversion, which matches the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@benlife5
benlife5 merged commit f5153f9 into main Oct 6, 2026
15 checks passed
@benlife5
benlife5 deleted the convert-template-err-messages branch October 6, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants