Repository navigation
feat: support complete list items in itemSource - #1354
briantstephan wants to merge 3 commits into
Conversation
![semgrep-code-yext[bot]](https://avatars.githubusercontent.com/b/149?s=60&v=4){kind=small}
| } | ||
| engines: { node: ">= 0.4" } | ||
|
|
||
| esbuild@0.21.5: |
There was a problem hiding this comment.
🟡 Medium severity issue identified in your code:
Risk: Affected versions of esbuild are vulnerable to Origin Validation Error. esbuild's development server responds to every request, including Server-Sent Events connections, with Access-Control-Allow-Origin: *. Any website a developer visits can therefore make cross-origin requests to the local dev server and read the responses, leaking bundled source code, source maps, and served file paths. Starting the dev server via serve() reaches the vulnerable code path.
Manual Review Advice: A vulnerability from this advisory is reachable if you run esbuild with the --serve flag to start the development server
Fix: Upgrade this library to at least version 0.25.0 at visual-editor/pnpm-lock.yaml:5131.
Reference(s): GHSA-67mh-4wv8-2f99
🎈 Fixed in commit 636a599 🎈
| @@ -6034,10 +6477,10 @@ packages: | |||
| } | |||
| engines: { node: ^18.17.0 || >=20.5.0 } | |||
|
|
|||
| mapbox-gl@3.30.0: | |||
| mapbox-gl@3.32.0: | |||
There was a problem hiding this comment.
Legal Risk
mapbox-gl 3.32.0 was released under the non-standard license, a license that
is currently prohibited by your organization. Merging is blocked until this is resolved.
Recommendation
Reach out to your security team or Semgrep admin to address this issue. In special cases, exceptions may be made for dependencies with violating licenses, however, the general recommendation is to avoid using a dependency under such a license.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| @@ -0,0 +1,68 @@ | |||
| import { type Migration } from "../../utils/migrate.ts"; | |||
There was a problem hiding this comment.
I guess the migration is a little weird since the photo gallery is not included in this branch, but I think we should keep the builtIn migration registry in sync until we stop supporting the OOTB artifact 👍
This branch has not been deployed
3 participants
Add complete-item selection and $item resolution through existing
itemSourceoptions. Clear old mappings when the source changes and automatically map complete items when exactly one mapping matches.This represents a subset of the changes from #1339, and is necessary to get the Photo Gallery
itemSourcechanges working instandard-librarysince that uses a 2.x release.Tested alongside the aforementioned Photo Gallery changes in
standard-library's local-editor and confirmed that everything worked as expected.