Repository navigation
chore(deps): upgrade MyGo to v0.8.3 - #37
Merged
Merged
Conversation
MyGo 0.8's breaking change is that HandleInput sees every key, modifiers included; Kando has no HandleInput handler, nor the drag, press or terminal APIs whose behavior changed, and migrate-ui finds nothing to migrate. The generated catalogs are unchanged, and every screenshot scene renders byte for byte as with v0.7.4. Tester.Click now clicks only the element a label names first, and breeze.ContentRow names its row with the same label as its field, so the feedback test clicks the rows' fields through a clickRow helper that checks the field took the focus.
github-actions
Bot
added
area: app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
github.com/egoist/mygofrom v0.7.4 to v0.8.3 (also the pinnedmygoCLI tool). breeze-ui, ai-logo/mygo and nodra stay where they are; they compile and pass against v0.8.3.What 0.8 changes and how Kando is affected
HandleInputsees every key, modifiers included, with the newInputEvent.Code. Kando has noHandleInputhandler, so nothing changes.Opacityfades a subtree as one, presses and drags follow the primary button only, a cancelled press commits nothing,mygo buildno longer ships Go sources fromresources/. Kando uses none of the drag or press APIs, and itsresources/only holdsicon.png.go tool mygo migrate-ui .finds nothing to migrate,go tool mygo generateleaves the catalogs' accessors unchanged, andgo tool mygo i18n checkpasses (755 messages in 5 languages).Test change
Tester.Clickbecame strict in 0.8: it clicks only the element a label names first and refuses when the point would reach another control.breeze.ContentRowlabels its row with the same name as the field inside, and the row does not hand clicks to its field, soTestFeedbackSendOpensThePrefilledIssuefailed ontt.Click("标题")(deterministically on 0.8.3, never on 0.7.4). A coordinate click on the row's middle still focuses the field in 0.8.3, so the UI is fine; the test now uses aclickRowhelper that clicks the row's middle and asserts the field took the focus.Screenshots
None: all 57 screenshot scenes (
KANDO_SCREENSHOTS=… go test -run TestScreenshots) render byte for byte the same on v0.7.4 and v0.8.3.Test plan
go vet ./...,go tool mygo vet .,go tool mygo migrate-ui .,go tool mygo i18n check .CGO_ENABLED=0 go test -count=1 ./packages/core/... ./packages/media/... ./apps/kando/...go tool mygo build apps/kando: the bundle builds with its icon and the five localizations