Repository navigation
chore(app): set the app identifier to ai.yldm.kando - #39
Merged
Merged
Conversation
github-actions
Bot
added
area: app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the template placeholder
com.example.kandoinapps/kando/mygo.jsonwithai.yldm.kando, the reverse of the kando.yldm.ai domain the site now lives on.MyGo makes this the app's identity on every platform: the macOS bundle ID (
CFBundleIdentifier), which the system keys preferences, the keychain and notarization on. No release has shipped yet, so no installed copy carries the old ID and nothing needs migrating.This also clears the release workflow's "Check the identifier" guard, which has failed every Release run so far. Once this is on main and CI passes, the Release workflow will cut the first version from the commits since the start of the repo.
Verification
CGO_ENABLED=0 go test ./...inapps/kandopasses.go tool mygo buildsucceeds and the builtKando.app/Contents/Info.plisthasCFBundleIdentifier=ai.yldm.kando.Screenshots
None.