Repository navigation
ci(tools): satisfy shellcheck - #41
Merged
Merged
Conversation
github-actions
Bot
added
area: ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#40 was merged before this fix reached its branch, so the Lint job fails on main with three shellcheck findings in
.github/scripts/build-tools.sh:tools.envis sourced from beside the script; the directive now disables the check instead of naming a path shellcheck is not run to follow.findinstead ofls.$ORIGINin the rpath is the linker's, so the single quotes are intended; disabled on that line.Also
sha256sum -- *in the Tools workflow, which actionlint flagged (SC2035).What the script builds is unchanged, and the
tools-1release stays as published.Verification
shellcheck .github/scripts/*.sh tools/mygo-dev/dev.sh(the Lint job's command) andactionlint .github/workflows/tools.ymlpass locally.Screenshots
None.