Repository navigation
Reject stray carriage returns instead of truncating - #9
Merged
Merged
Conversation
The CRLF fix treated every '\r' as an end-of-line, so a file with CR-only line endings (or a stray '\r') silently loaded only its first record. Only end a line at a '\r' followed by '\n' or EOF; otherwise let strtol() report the malformed index. Add a regression test for a CR-only file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8.
The CRLF fix stopped the feature loop at every
\r, so a file usingCR-only line endings (or containing a stray
\r) silently loaded onlyits first record. A
\ris now treated as a line ending only when it isfollowed by
\n(CRLF) or EOF; otherwisestrtol()reports themalformed index, as it did before.
Added a regression test for a CR-only file.
Verified locally: 19 tests pass with numpy 1.26.4 and numpy 2.5.4,
Cython 3.3.0.