Repository navigation
refactor!: drop the compatibility with earlier MCloud releases - #226
Merged
Merged
Conversation
The current mcloud head always has its ZeroMQ CURVE keys and the token of the STF storage, mcloud-agent always passes them, and the device units of the current STF have no database. Removed: - STORAGE_TOKEN, the copy of STF_STORAGE_TOKEN for the STF images up to 3.0-hardening - RETHINKDB_PORT_28015_TCP, awaited for the device units of the earlier STF images - ZeroMQ without CURVE: the "both or none" check of the keys and the INFO/WARN log line about the ZeroMQ security STF_ZMQ_CURVE_SERVER_PUBLIC_KEY, STF_ZMQ_CURVE_SECRET_KEY and STF_STORAGE_TOKEN are required: an empty or unset one is a configuration error (exit 0); the keys are still checked for 64 hex characters. STF_PROVIDER_CONNECT_APP_DEALER and STF_PROVIDER_CONNECT_DEV_DEALER stay, stf ios-device uses them. BREAKING CHANGE: a device host or a head of an earlier release without the CURVE keys or the storage token, or with an STF image that reads STORAGE_TOKEN or needs RethinkDB, is not supported: the container exits with a configuration error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current mcloud head always has its ZeroMQ CURVE keys and the token of the STF storage, mcloud-agent always passes them, and the device units of the current STF have no database. This drops what existed only for the earlier releases of the farm.
Removed
STORAGE_TOKEN: the copy ofSTF_STORAGE_TOKENfor the STF images up to3.0-hardening(entrypoint, README, tests).RETHINKDB_PORT_28015_TCP: awaited for the device units of the earlier STF images (entrypoint,DockerfileENV, README, entrypoint and image tests, the fake RethinkDB port oftests/image_test.sh).Mandatory now
STF_ZMQ_CURVE_SERVER_PUBLIC_KEY,STF_ZMQ_CURVE_SECRET_KEY: required, still checked for 64 hex characters.STF_STORAGE_TOKEN: required (it was optional, an empty one left the storage calls without the token).An empty or unset one is a configuration error:
<VAR> is required but empty or unset., thenInvalid configuration. Exiting!with exit code0, as for the other required variables. The values are not logged. They stay declared empty in theDockerfileENV as the other required variables, the README documents them as required.Kept:
STF_PROVIDER_CONNECT_APP_DEALER/STF_PROVIDER_CONNECT_DEV_DEALER(used by the currentstf ios-device).Breaking
A device host or a head of an earlier MCloud release is not supported: without the CURVE keys or the storage token the container exits with a configuration error, and an STF base image that reads
STORAGE_TOKENor needs RethinkDB does not get them anymore.Checks
make test:tests/entrypoint_test.sh360 checks pass (the no-CURVE andSTORAGE_TOKENtests are replaced by "a missing key/token is a configuration error" for Android and iOS, and by checks that STF gets the keys and the token, which are not logged).tests/repo_test.shfails one check that fails ondeveloptoo: the base imagestf:3.1has no digest (not published yet).make lint: one failure, the same one as ondevelop(the README lists the Dockerfile version ofFROM ...stf:...@: no digest forstf:3.1).make dockernot run:public.ecr.aws/zebrunner/stf:3.1is not published (no such manifest).tests/image_test.shis updated: the containers get the token and the keys, the configuration validation checks the three required variables.