Repository navigation
fix(auth): tighten sign-in "next" redirect to path-only targets - #151
Open
bintest000001-ux wants to merge 1 commit into
Open
bintest000001-ux wants to merge 1 commit into
bintest000001-ux wants to merge 1 commit into
Conversation
Only accept a single leading "/" not followed by "/" or "\" and no scheme in the sign-in redirect target; anything else falls back to /explore so the page cannot be used as an open redirect. Adds a unit-tested validator (node:test) and a test:unit script wired into CI. Fixes zeemscript#68. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68.
What changed
ContributorLoginaccepted anynextvalue starting with/, so//example.com(protocol-relative) and/\example.compassed the check and made the sign-in page a possible open redirect.src/lib/redirect.tswithsafeRedirectTarget(): only same-origin, path-only values are accepted — a single leading/not followed by/or\, and no scheme. Anything else falls back to/explore. The existing/loginloop guard is preserved.src/pages/auth.tsx(destcalculation).src/lib/redirect.test.tsunit tests covering/issue/1(allowed) and//example.com,/\example.com,https://example.com,javascript:alert(1),/login...(rejected), using Node's native test runner.test:unitscript, run in CI before the build.Verification
npm run test:unit— 7/7 passnpm run build(tsc + vite) — passes🤖 Generated with Claude Code