Conversation
…ntation calls Update `textwrap` dependency in `serde-generate` from 0.13.4 to 0.16.4. Since `textwrap::indent` automatically prefixes empty lines with the trimmed prefix (e.g. `//`, `///`, `*`), the post-processing `.replace` calls across all code generators (`cpp`, `csharp`, `dart`, `golang`, `java`, `kotlin`, `rust`, `swift`, `typescript`) are redundant and have been removed.
mgeisler
force-pushed
the
update-textwrap
branch
from
September 15, 2026 19:58
751226f to
27d3812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
textwrapdependency inserde-generatefrom 0.13.4 to 0.16.4.Since
textwrap::indentautomatically prefixes empty lines with the trimmed prefix (e.g.//,///,*), the post-processing.replacecalls across all code generators (cpp,csharp,dart,golang,java,kotlin,rust,swift,typescript) are redundant and have been removed.Test Plan
I ran
cargo testfor the Rust and Go generators.