fix(orm): type parameterized computed field args from the field's params metadata

[evgenovalov]

Problem

args of a parameterized computed field were typed off the generated computedFields stub, whose non-scalar params (enums, type defs, models, Json) are emitted as unknown. So for

enum Status { ACTIVE INACTIVE }
type ViewFilter { minViews Int }

model User {
  postCountByStatus(status: Status) Int @computed
  popularPostCount(filter: ViewFilter) Int @computed
}

all of these compiled, and the implementation callback saw args.status / args.filter as unknown:

db.user.findMany({ select: { postCountByStatus: { args: { status: 'WRONG' } } } });
db.user.findMany({ where: { postCountByStatus: { args: { status: 'WRONG' }, gt: 0 } } });
const s: UserSelect = { popularPostCount: { args: { filter: { minViews: 'x' } } } };

Runtime zod validation was already precise (it builds the args schema from the field's params), so typing and validation had drifted apart.

Fix

• orm: ComputedFieldArgs now derives from the field's params metadata, reusing the param mapping procedures already use (MapParamsObject / MapParam, renamed from the procedure-specific names): scalars → TS types, enums → value union, type defs → object shape, optional → optional key. ComputedFieldsOptions reads the same source, so the implementation signature and the query input types can't disagree. This also covers parameterized computed fields inherited by delegate sub-models (their field defs carry params).
• sdk: the stub parameter is renamed to _args (the bare args tripped noUnusedParameters in consuming projects), and enum params in the stub are emitted as SchemaType["enums"]["X"]["values"][keyof ...] instead of unknown. Type-def params remain unknown in the stub only, since schema.ts has no TS type for type defs; the ORM/input.ts typing resolves them precisely.

Tests

• e2e computed-fields.test.ts: a runtime test with enum + type-def params (including zod rejection of a wrong enum value and a wrong type-def payload), and a compile-time test asserting wrong args fail in select / where / orderBy, in the implementation callback, and in the generated UserSelect / UserWhereInput types.
• typing schema: added hasStatus(status: Status) Boolean @computed with @ts-expect-error assertions in typecheck.ts.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Parameterized computed fields now derive query and implementation argument types from declared schema parameters.
  • Generated TypeScript typings support scalar, enum, array, and type-definition parameters.
  • Enum and structured arguments are validated for computed-field queries.

• Bug Fixes

  • Improved type accuracy for optional and required computed-field arguments.

• Tests

  • Added coverage for runtime filtering, invalid arguments, optional parameters, and generated TypeScript typings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: c551d2df-75bd-4ee5-af24-aa1e5935e556

📥 Commits

Reviewing files that changed from the base of the PR and between d238bf3 and bd2c2e1.

📒 Files selected for processing (1)

• tests/e2e/orm/client-api/computed-fields.test.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

Changes

Parameterized computed field typing

Layer / File(s)	Summary
Generate computed-field parameter types packages/sdk/src/ts-schema-generator.ts	Generated computed-field stubs now use AST-based parameter types for scalar, enum, array, and unsupported references.
Map schema parameters into ORM types packages/orm/src/client/crud-types.ts, packages/orm/src/client/options.ts	Computed-field arguments and implementation parameters now derive from schema params metadata. Shared parameter helpers also support procedures.
Validate generated and query-time typing tests/e2e/orm/client-api/computed-fields.test.ts, tests/e2e/orm/schemas/typing/*	Tests cover enum and type-definition arguments, runtime validation, optional parameters, and query input type checking.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to bd2c2

The test now accepts the PostgreSQL driver's string bigint count representation without changing product behavior. No current merge-blocking risk remains.

Suggested reviewers: ymc9

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 6 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: deriving parameterized computed field argument types from field params metadata.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}